maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mlir] check for failures when packing function sigunatures in std->llvm conversion 

When packing function results into a structure during the standard-to-llvm
dialect conversion, do not assume the conversion was successful and propagate
nullptr as error state.

Fixes PR45184.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D87605
This commit is contained in:
Alex Zinenko 2020-09-14 13:47:27 +02:00
parent c20852300a
commit 967c7b6936
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
View File

@ -3390,7 +3390,7 @@ Type LLVMTypeConverter::packFunctionResults(ArrayRef<Type> types) {
SmallVector<LLVM::LLVMType, 8> resultTypes;
resultTypes.reserve(types.size());
for (auto t : types) {
auto converted = convertType(t).dyn_cast<LLVM::LLVMType>();
auto converted = convertType(t).dyn_cast_or_null<LLVM::LLVMType>();
if (!converted)
return {};
resultTypes.push_back(converted);

4
mlir/test/Conversion/StandardToLLVM/invalid.mlir
View File

@ -34,3 +34,7 @@ func @mlir_cast_to_llvm_vec(%0 : vector<1x1xf32>) -> !llvm.vec<1 x float> {
// Should not crash on unsupported types in function signatures.
func @unsupported_signature() -> tensor<10 x i32>
// -----
func @partially_supported_signature() -> (vector<10 x i32>, tensor<10 x i32>)