maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[gn build] Fix defines define on Windows 

On Windows, we won't go into the `host_os != "win"` block, so `defines`
won't have been defined, and we'll run into an undefined identifier
error when we try to later append to it. Unconditionally define it at
the start and append to it everywhere else.

Differential Revision: https://reviews.llvm.org/D55617

llvm-svn: 348993
This commit is contained in:
Shoaib Meenai 2018-12-12 23:57:21 +00:00
parent d001e0e0f4
commit 95f6875187
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/utils/gn/build/BUILD.gn
View File

@ -3,9 +3,11 @@ import("//llvm/utils/gn/build/mac_sdk.gni")
import("//llvm/utils/gn/build/toolchain/compiler.gni") import("//llvm/utils/gn/build/toolchain/compiler.gni")
config("compiler_defaults") { config("compiler_defaults") {
defines = []
# FIXME: Don't define this globally here. # FIXME: Don't define this globally here.
if (host_os != "win") { if (host_os != "win") {
defines = [ "LLVM_ON_UNIX" ] defines += [ "LLVM_ON_UNIX" ]
} }
if (!llvm_enable_assertions) { if (!llvm_enable_assertions) {