maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MLIR] NFC Fix/clarify line in const usage rationale doc 

Update misleading line in conclusions. Although the application to IR
objects is stated earlier, the concluding section contradicts it in
isolation.

Differential Revision: https://reviews.llvm.org/D78446
This commit is contained in:
Uday Bondhugula 2020-04-19 11:10:31 +05:30
parent 2abd50a359
commit 9412e4c9c6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mlir/docs/Rationale/UsageOfConst.md
View File

@ -257,8 +257,8 @@ As we can see above, there is very little benefit to our const design and
significant cost, and given that the primary purpose of an IR is to represent
transformations of code, const is providing very little benefit.
As such, we propose eliminating support for const references in MLIR. This
implies the following changes to the codebase:
As such, we propose eliminating support for const references to IR objects in
MLIR. This implies the following changes to the codebase:
1. All of the const-duplicated accessors would be eliminated, e.g.
`Operation::getParent() const` would be removed. This is expected to remove