diff --git a/lldb/include/lldb/Core/PluginManager.h b/lldb/include/lldb/Core/PluginManager.h index e833e703ecea..c09f5a3fa7b5 100644 --- a/lldb/include/lldb/Core/PluginManager.h +++ b/lldb/include/lldb/Core/PluginManager.h @@ -449,7 +449,8 @@ public: static bool RegisterPlugin (const ConstString &name, const char *description, - REPLCreateInstance create_callback); + REPLCreateInstance create_callback, + REPLEnumerateSupportedLanguages enumerate_languages_callback); static bool UnregisterPlugin (REPLCreateInstance create_callback); @@ -460,6 +461,12 @@ public: static REPLCreateInstance GetREPLCreateCallbackForPluginName (const ConstString &name); + static REPLEnumerateSupportedLanguages + GetREPLEnumerateSupportedLanguagesCallbackAtIndex (uint32_t idx); + + static REPLEnumerateSupportedLanguages + GetREPLSystemEnumerateSupportedLanguagesCallbackForPluginName (const ConstString &name); + //------------------------------------------------------------------ // Some plug-ins might register a DebuggerInitializeCallback // callback when registering the plug-in. After a new Debugger diff --git a/lldb/include/lldb/Target/Language.h b/lldb/include/lldb/Target/Language.h index 555f1e27abea..57ef8b5ef89d 100644 --- a/lldb/include/lldb/Target/Language.h +++ b/lldb/include/lldb/Target/Language.h @@ -149,6 +149,9 @@ public: static void GetLanguagesSupportingTypeSystems (std::set &languages, std::set &languages_for_expressions); + + static void + GetLanguagesSupportingREPLs (std::set &languages); protected: //------------------------------------------------------------------ diff --git a/lldb/include/lldb/lldb-private-interfaces.h b/lldb/include/lldb/lldb-private-interfaces.h index 22bdd18ac2a5..6bc8dadaebff 100644 --- a/lldb/include/lldb/lldb-private-interfaces.h +++ b/lldb/include/lldb/lldb-private-interfaces.h @@ -51,6 +51,7 @@ namespace lldb_private typedef lldb::TypeSystemSP (*TypeSystemCreateInstance) (lldb::LanguageType language, Module *module, Target *target); typedef lldb::REPLSP (*REPLCreateInstance) (Error &error, lldb::LanguageType language, Debugger *debugger, Target *target, const char *repl_options); typedef void (*TypeSystemEnumerateSupportedLanguages) (std::set &languages_for_types, std::set &languages_for_expressions); + typedef void (*REPLEnumerateSupportedLanguages) (std::set &languages); typedef int (*ComparisonFunction)(const void *, const void *); typedef void (*DebuggerInitializeCallback)(Debugger &debugger); diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp index 8619b50b2a31..494b762e872e 100644 --- a/lldb/source/Core/Debugger.cpp +++ b/lldb/source/Core/Debugger.cpp @@ -1805,11 +1805,6 @@ Debugger::RunREPL (LanguageType language, const char *repl_options) { Error err; FileSpec repl_executable; - if (language == eLanguageTypeUnknown) - { - err.SetErrorString ("must specify a language for a REPL"); // TODO make it possible to specify a default language - return err; - } Target *const target = nullptr; // passing in an empty target means the REPL must create one diff --git a/lldb/source/Core/PluginManager.cpp b/lldb/source/Core/PluginManager.cpp index 97116dd4ad83..a90b57678b7a 100644 --- a/lldb/source/Core/PluginManager.cpp +++ b/lldb/source/Core/PluginManager.cpp @@ -2662,6 +2662,7 @@ struct REPLInstance ConstString name; std::string description; REPLCreateInstance create_callback; + REPLEnumerateSupportedLanguages enumerate_languages_callback; }; typedef std::vector REPLInstances; @@ -2683,7 +2684,8 @@ GetREPLInstances () bool PluginManager::RegisterPlugin (const ConstString &name, const char *description, - REPLCreateInstance create_callback) + REPLCreateInstance create_callback, + REPLEnumerateSupportedLanguages enumerate_languages_callback) { if (create_callback) { @@ -2693,6 +2695,7 @@ PluginManager::RegisterPlugin (const ConstString &name, if (description && description[0]) instance.description = description; instance.create_callback = create_callback; + instance.enumerate_languages_callback = enumerate_languages_callback; Mutex::Locker locker (GetREPLMutex ()); GetREPLInstances ().push_back (instance); } @@ -2748,6 +2751,35 @@ PluginManager::GetREPLCreateCallbackForPluginName (const ConstString &name) return NULL; } +REPLEnumerateSupportedLanguages +PluginManager::GetREPLEnumerateSupportedLanguagesCallbackAtIndex (uint32_t idx) +{ + Mutex::Locker locker (GetREPLMutex ()); + REPLInstances &instances = GetREPLInstances (); + if (idx < instances.size()) + return instances[idx].enumerate_languages_callback; + return NULL; +} + + +REPLEnumerateSupportedLanguages +PluginManager::GetREPLSystemEnumerateSupportedLanguagesCallbackForPluginName (const ConstString &name) +{ + if (name) + { + Mutex::Locker locker (GetREPLMutex ()); + REPLInstances &instances = GetREPLInstances (); + + REPLInstances::iterator pos, end = instances.end(); + for (pos = instances.begin(); pos != end; ++ pos) + { + if (name == pos->name) + return pos->enumerate_languages_callback; + } + } + return NULL; +} + #pragma mark PluginManager void diff --git a/lldb/source/Target/Language.cpp b/lldb/source/Target/Language.cpp index 3ca6ae7f2705..a2855b76e7ee 100644 --- a/lldb/source/Target/Language.cpp +++ b/lldb/source/Target/Language.cpp @@ -299,6 +299,17 @@ Language::GetLanguagesSupportingTypeSystems (std::set &langu } } +void +Language::GetLanguagesSupportingREPLs (std::set &languages) +{ + uint32_t idx = 0; + + while (REPLEnumerateSupportedLanguages enumerate = PluginManager::GetREPLEnumerateSupportedLanguagesCallbackAtIndex(idx++)) + { + (*enumerate)(languages); + } +} + std::unique_ptr Language::GetTypeScavenger () { diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index 385ac74bb1d4..23b82e5c36eb 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -218,7 +218,19 @@ Target::GetREPL (Error &err, lldb::LanguageType language, const char *repl_optio { if (language == eLanguageTypeUnknown) { - return REPLSP(); // must provide a language + std::set repl_languages; + + Language::GetLanguagesSupportingREPLs(repl_languages); + + if (repl_languages.size() == 1) + { + language = *repl_languages.begin(); + } + else + { + err.SetErrorStringWithFormat("Multiple possible REPL languages. Please specify a language."); + return REPLSP(); // must provide a language + } } REPLMap::iterator pos = m_repl_map.find(language);