maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fixing a bug creating floating point constants of type other 

than double through the C bindings. Thanks to Tomas Lindquist
Olsen for reporting it.

llvm-svn: 46656
This commit is contained in:
Gordon Henriksen 2008-02-02 01:07:50 +00:00
parent 4e7ff941f1
commit 931e121ad1
3 changed files with 35 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
llvm/include/llvm-c/Core.h
View File

@ -289,6 +289,7 @@ int LLVMIsUndef(LLVMValueRef Val);
LLVMValueRef LLVMConstInt(LLVMTypeRef IntTy, unsigned long long N, LLVMValueRef LLVMConstInt(LLVMTypeRef IntTy, unsigned long long N,
int SignExtend); int SignExtend);
LLVMValueRef LLVMConstReal(LLVMTypeRef RealTy, double N); LLVMValueRef LLVMConstReal(LLVMTypeRef RealTy, double N);
LLVMValueRef LLVMConstRealOfString(LLVMTypeRef RealTy, const char *Text);
/* Operations on composite constants */ /* Operations on composite constants */
LLVMValueRef LLVMConstString(const char *Str, unsigned Length, LLVMValueRef LLVMConstString(const char *Str, unsigned Length,

24
llvm/lib/VMCore/Core.cpp
View File

@ -284,8 +284,30 @@ LLVMValueRef LLVMConstInt(LLVMTypeRef IntTy, unsigned long long N,
return wrap(ConstantInt::get(unwrap<IntegerType>(IntTy), N, SignExtend != 0)); return wrap(ConstantInt::get(unwrap<IntegerType>(IntTy), N, SignExtend != 0));
} }
static const fltSemantics &SemanticsForType(Type *Ty) {
assert(Ty->isFloatingPoint() && "Type is not floating point!");
if (Ty == Type::FloatTy)
return APFloat::IEEEsingle;
if (Ty == Type::DoubleTy)
return APFloat::IEEEdouble;
if (Ty == Type::X86_FP80Ty)
return APFloat::x87DoubleExtended;
if (Ty == Type::FP128Ty)
return APFloat::IEEEquad;
if (Ty == Type::PPC_FP128Ty)
return APFloat::PPCDoubleDouble;
return APFloat::Bogus;
}
LLVMValueRef LLVMConstReal(LLVMTypeRef RealTy, double N) { LLVMValueRef LLVMConstReal(LLVMTypeRef RealTy, double N) {
return wrap(ConstantFP::get(unwrap(RealTy), APFloat(N))); APFloat APN(N);
APN.convert(SemanticsForType(unwrap(RealTy)), APFloat::rmNearestTiesToEven);
return wrap(ConstantFP::get(unwrap(RealTy), APN));
}
LLVMValueRef LLVMConstRealOfString(LLVMTypeRef RealTy, const char *Text) {
return wrap(ConstantFP::get(unwrap(RealTy),
APFloat(SemanticsForType(unwrap(RealTy)), Text)));
} }
/*--.. Operations on composite constants ...................................--*/ /*--.. Operations on composite constants ...................................--*/

16
llvm/test/Bindings/Ocaml/vmcore.ml
View File

@ -211,12 +211,18 @@ let test_constants () =
ignore (define_global "Const05" c m); ignore (define_global "Const05" c m);
insist ((array_type i8_type 9) = type_of c); insist ((array_type i8_type 9) = type_of c);
(* RUN: grep {Const06.*3.1459} < %t.ll (* RUN: grep {ConstSingle.*2.75} < %t.ll
* RUN: grep {ConstDouble.*3.1459} < %t.ll
*) *)
group "real"; begin group "real";
let c = const_float double_type 3.1459 in let cs = const_float float_type 2.75 in
ignore (define_global "Const06" c m); ignore (define_global "ConstSingle" cs m);
insist (double_type = type_of c); insist (float_type = type_of cs);
let cd = const_float double_type 3.1459 in
ignore (define_global "ConstDouble" cd m);
insist (double_type = type_of cd)
end;
let one = const_int i16_type 1 in let one = const_int i16_type 1 in
let two = const_int i16_type 2 in let two = const_int i16_type 2 in