maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[test] Add a FIXME test for stop-command-source-on-error 

Modifying the interpreter settings is tricky because they don't take
effect until we create a new command interpreter, which should be merely
an implementation detail. This leads to confusing and unexpected
scenarios.

This adds a test cases with FIXMEs for some of the odd scenarios I
encountered. I didn't XFAIL the test because I don't think there's a way
to get an unexpected PASS if any of the commands succeeds and splitting
up the file in multiple tests seems excessive.

llvm-svn: 371259
This commit is contained in:
Jonas Devlieghere 2019-09-06 21:43:33 +00:00
parent b482db6dfe
commit 92ada4ab0c
3 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/lit/Settings/Inputs/DontStopCommandSource.in Normal file
View File

@ -0,0 +1,3 @@
settings set interpreter.stop-command-source-on-error false
bogus
print 123400000 + 56789

3
lldb/lit/Settings/Inputs/StopCommandSource.in Normal file
View File

@ -0,0 +1,3 @@
settings set interpreter.stop-command-source-on-error true
bogus
print 123400000 + 56789

24
lldb/lit/Settings/TestStopCommandSourceOnError.test Normal file
View File

@ -0,0 +1,24 @@
# Modifying the interpreter settings is tricky because they don't take effect
# until we create a new command interpreter, which should be merely an
# implementation detail. This leads to confusing and unexpected scenarios.
#
# Below are a few scenarios that we should fix.
# CONTINUE: 123456789
# STOP-NOT: 111111111
# STOP-NOT: 123456789
# FIXME: Should stop
# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -s %S/Inputs/StopCommandSource.in | FileCheck %s --check-prefix CONTINUE
# FIXME: Should continue
# RUN: %lldb -b -s %S/Inputs/DontStopCommandSource.in -o 'bogus' -o 'print 111100000 + 11111' | FileCheck %s --check-prefix STOP
# FIXME: Should continue
# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -o 'bogus' -o 'print 123400000 + 56789' | FileCheck %s --check-prefix STOP
# FIXME: Should continue
# RUN: %lldb -b -s %S/Inputs/DontStopCommandSource.in | FileCheck %s --check-prefix STOP
# FIXME: Should continue
# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error true' -s %S/Inputs/DontStopCommandSource.in | FileCheck %s --check-prefix STOP