From 928a95d0b0ad71de454014c9eca348e82929eb13 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 22 Jun 2016 22:09:17 +0000 Subject: [PATCH] Use shouldAssumeDSOLocal. With this it handle -fPIE. llvm-svn: 273499 --- llvm/lib/Target/PowerPC/PPCISelLowering.cpp | 10 +++++----- llvm/test/CodeGen/PowerPC/pie.ll | 16 ++++++++++++++++ 2 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 llvm/test/CodeGen/PowerPC/pie.ll diff --git a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp index 68d1a679e835..1df07071f8ef 100644 --- a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp +++ b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp @@ -23,6 +23,7 @@ #include "llvm/ADT/Statistic.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/ADT/Triple.h" +#include "llvm/CodeGen/Analysis.h" #include "llvm/CodeGen/CallingConvLower.h" #include "llvm/CodeGen/MachineFrameInfo.h" #include "llvm/CodeGen/MachineFunction.h" @@ -4287,11 +4288,10 @@ PrepareCall(SelectionDAG &DAG, SDValue &Callee, SDValue &InFlag, SDValue &Chain, Reloc::Model RM = DAG.getTarget().getRelocationModel(); const Triple &TargetTriple = Subtarget.getTargetTriple(); const GlobalValue *GV = G->getGlobal(); - if ((RM != Reloc::Static && - (TargetTriple.isMacOSX() && TargetTriple.isMacOSXVersionLT(10, 5)) && - !GV->isStrongDefinitionForLinker()) || - (Subtarget.isTargetELF() && !isPPC64 && !GV->hasLocalLinkage() && - RM == Reloc::PIC_)) { + bool OldMachOLinker = + TargetTriple.isMacOSX() && TargetTriple.isMacOSXVersionLT(10, 5); + if (!shouldAssumeDSOLocal(RM, TargetTriple, *GV->getParent(), GV) && + (OldMachOLinker || (Subtarget.isTargetELF() && !isPPC64))) { // PC-relative references to external symbols should go through $stub, // unless we're building with the leopard linker or later, which // automatically synthesizes these stubs. diff --git a/llvm/test/CodeGen/PowerPC/pie.ll b/llvm/test/CodeGen/PowerPC/pie.ll new file mode 100644 index 000000000000..56e07caf2812 --- /dev/null +++ b/llvm/test/CodeGen/PowerPC/pie.ll @@ -0,0 +1,16 @@ +; RUN: llc < %s -mtriple=powerpc-pc-linux -relocation-model=pic | FileCheck %s + + +define void @f() { + ret void +} + +define void @g() { +; CHECK: g: +; CHECK: bl f{{$}} + call void @f() + ret void +} + +!llvm.module.flags = !{!0} +!0 = !{i32 1, !"PIE Level", i32 1}