[libc++] Adjust XFAIL markup for modules tests on single-threaded systems

When building these tests without modules in the whole test suite,
the __config_site macro definitions are not included anymore in the
%{compile_flags}. This causes the _LIBCPP_HAS_NO_THREADS define not
to be picked up, and the test to XPASS on single-threaded systems.

This is a stop-gap measure to fix the build bots, however the proper
solution would be to always pass the __config_site defines as compiler
macros, whether we build with modules or not.
This commit is contained in:
Louis Dionne 2020-04-15 14:17:40 -04:00
parent 6c9d52885d
commit 91f110f50e
6 changed files with 27 additions and 5 deletions

View File

@ -12,7 +12,10 @@
// FIXME: The <atomic> header is not supported for single-threaded systems,
// but still gets built as part of the 'std' module, which breaks the build.
// XFAIL: libcpp-has-no-threads
// The failure only shows up when modules are enabled AND we're building
// without threads, which is when the __config_site macro for _LIBCPP_HAS_NO_THREADS
// is honored.
// XFAIL: libcpp-has-no-threads && -fmodules
// REQUIRES: modules-support
// ADDITIONAL_COMPILE_FLAGS: -fmodules

View File

@ -12,7 +12,10 @@
// FIXME: The <atomic> header is not supported for single-threaded systems,
// but still gets built as part of the 'std' module, which breaks the build.
// XFAIL: libcpp-has-no-threads
// The failure only shows up when modules are enabled AND we're building
// without threads, which is when the __config_site macro for _LIBCPP_HAS_NO_THREADS
// is honored.
// XFAIL: libcpp-has-no-threads && -fmodules
// UNSUPPORTED: c++98, c++03

View File

@ -12,7 +12,10 @@
// FIXME: The <atomic> header is not supported for single-threaded systems,
// but still gets built as part of the 'std' module, which breaks the build.
// XFAIL: libcpp-has-no-threads
// The failure only shows up when modules are enabled AND we're building
// without threads, which is when the __config_site macro for _LIBCPP_HAS_NO_THREADS
// is honored.
// XFAIL: libcpp-has-no-threads && -fmodules
// Test that <cstdint> re-exports <stdint.h>

View File

@ -12,7 +12,10 @@
// FIXME: The <atomic> header is not supported for single-threaded systems,
// but still gets built as part of the 'std' module, which breaks the build.
// XFAIL: libcpp-has-no-threads
// The failure only shows up when modules are enabled AND we're building
// without threads, which is when the __config_site macro for _LIBCPP_HAS_NO_THREADS
// is honored.
// XFAIL: libcpp-has-no-threads && -fmodules
// Test that intypes.h re-exports stdint.h

View File

@ -8,7 +8,10 @@
// FIXME: The <atomic> header is not supported for single-threaded systems,
// but still gets built as part of the 'std' module, which breaks the build.
// XFAIL: libcpp-has-no-threads
// The failure only shows up when modules are enabled AND we're building
// without threads, which is when the __config_site macro for _LIBCPP_HAS_NO_THREADS
// is honored.
// XFAIL: libcpp-has-no-threads && -fmodules
// Test that int8_t and the like are exported from stdint.h, not inttypes.h

View File

@ -15,6 +15,13 @@
// are not modular
// XFAIL: LIBCXX-WINDOWS-FIXME
// FIXME: The <atomic> header is not supported for single-threaded systems,
// but still gets built as part of the 'std' module, which breaks the build.
// The failure only shows up when modules are enabled AND we're building
// without threads, which is when the __config_site macro for _LIBCPP_HAS_NO_THREADS
// is honored.
// XFAIL: libcpp-has-no-threads && -fmodules
// REQUIRES: modules-support
// NOTE: The -std=XXX flag is present in %{flags}, so we overwrite it by passing it after %{flags}.