maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test 

Remove the test checking error message for 'is a directory'.  It does
not seem to serve any real purpose, and it relies on matching platform
error strings which are unpredictable and makes the test fragile.
Furthermore, it fails on NetBSD where read() works on directories,
and therefore does not return EISDIR at all.

Fixes r362141.

Differential Revision: https://reviews.llvm.org/D62773

llvm-svn: 362404
This commit is contained in:
Michal Gorny 2019-06-03 14:50:03 +00:00
parent 2b369f83c5
commit 9158d57d19
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
View File

@ -15,8 +15,3 @@ MACHO_DSYM: (__TEXT,__text) section
// RUN: llvm-objdump -m -d -g -dsym %p/../Inputs/libbogus11.a %p/../../dsymutil/Inputs/basic.macho.x86_64 2>&1 | FileCheck -check-prefix BAD_INPUT %s
BAD_INPUT: is not a Mach-O or Universal file type.
// RUN: not llvm-objdump -m -d -g -dsym %p/Inputs %p/Inputs/hello-macho-thin 2>&1 | FileCheck -check-prefix DIRECTORY %s
// Windows will emit "Is a directory", whereas others emit "is a directory"
DIRECTORY: {{[i|I]}}s a directory