maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[AggressiveInstCombine] Fix `TruncInstCombine` (fix f84d732f) 

Erase phi-nodes from `InstInfoMap` before erasing themselves
This commit is contained in:
Anton Afanasyev 2022-02-25 08:04:11 +03:00
parent 0dd8401371
commit 904a00d17a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp
View File

@ -504,6 +504,7 @@ void TruncInstCombine::ReduceExpressionGraph(Type *SclTy) {
for (auto &Node : OldNewPHINodes) {
PHINode *OldPN = Node.first;
OldPN->replaceAllUsesWith(PoisonValue::get(OldPN->getType()));
InstInfoMap.erase(OldPN);
OldPN->eraseFromParent();
}
// Now we have expression graph turned into dag.
@ -511,9 +512,6 @@ void TruncInstCombine::ReduceExpressionGraph(Type *SclTy) {
// visit any of its operands, this way, when we get to the operand, we already
// removed the instructions (from the expression dag) that uses it.
for (auto &I : llvm::reverse(InstInfoMap)) {
// Skip phi-nodes since they were erased before
if (isa<PHINode>(I.first))
continue;
// We still need to check that the instruction has no users before we erase
// it, because {SExt, ZExt}Inst Instruction might have other users that was
// not reduced, in such case, we need to keep that instruction.