maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc++/abi] Fix broken Lit feature no-noexcept-function-type 

The feature was always defined, which means that the two test cases
guarded by it were never run.

Differential Revision: https://reviews.llvm.org/D106062
This commit is contained in:
Louis Dionne 2021-07-15 09:43:47 -04:00
parent f8cb78e99a
commit 8fb47456a3
4 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libcxx/utils/libcxx/test/features.py
View File

@ -42,6 +42,7 @@ DEFAULT_FEATURES = [
Feature(name='has-fobjc-arc', when=lambda cfg: hasCompileFlag(cfg, '-xobjective-c++ -fobjc-arc') and
sys.platform.lower().strip() == 'darwin'), # TODO: this doesn't handle cross-compiling to Apple platforms.
Feature(name='objective-c++', when=lambda cfg: hasCompileFlag(cfg, '-xobjective-c++ -fobjc-arc')),
Feature(name='no-noexcept-function-type', when=lambda cfg: featureTestMacros(cfg).get('__cpp_noexcept_function_type', 0) < 201510),
Feature(name='non-lockfree-atomics',
when=lambda cfg: sourceBuilds(cfg, """

5
libcxxabi/test/catch_function_03.pass.cpp
View File

@ -7,7 +7,10 @@
//===----------------------------------------------------------------------===//
// Can a noexcept function pointer be caught by a non-noexcept catch clause?
// UNSUPPORTED: no-exceptions, libcxxabi-no-noexcept-function-type
// UNSUPPORTED: no-exceptions, no-noexcept-function-type
// Support for catching a function pointer including noexcept was shipped in macOS 10.13
// XFAIL: use_system_cxx_lib && {{.+}}-apple-macosx10.{{9|10|11|12}}
#include <cassert>

8
libcxxabi/test/catch_member_function_pointer_02.pass.cpp
View File

@ -6,9 +6,11 @@
//
//===----------------------------------------------------------------------===//
// Can a noexcept member function pointer be caught by a non-noexcept catch
// clause?
// UNSUPPORTED: no-exceptions, libcxxabi-no-noexcept-function-type
// Can a noexcept member function pointer be caught by a non-noexcept catch clause?
// UNSUPPORTED: no-exceptions, no-noexcept-function-type
// Support for catching a function pointer including noexcept was shipped in macOS 10.13
// XFAIL: use_system_cxx_lib && {{.+}}-apple-macosx10.{{9|10|11|12}}
// GCC 7 and 8 support noexcept function types but this test still fails.
// This is likely a bug in their implementation. Investigation needed.

5
libcxxabi/test/libcxxabi/test/config.py
View File

@ -37,13 +37,8 @@ class Configuration(LibcxxConfiguration):
self.libcxxabi_obj_root = self.get_lit_conf('libcxxabi_obj_root')
super(Configuration, self).configure_obj_root()
def has_cpp_feature(self, feature, required_value):
return intMacroValue(self.cxx.dumpMacros().get('__cpp_' + feature, '0')) >= required_value
def configure_features(self):
super(Configuration, self).configure_features()
if not self.has_cpp_feature('noexcept_function_type', 201510):
self.config.available_features.add('libcxxabi-no-noexcept-function-type')
if not self.get_lit_bool('llvm_unwinder', False):
self.config.available_features.add('libcxxabi-has-system-unwinder')