diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp index 989d01e2e395..462615037189 100644 --- a/llvm/lib/IR/Verifier.cpp +++ b/llvm/lib/IR/Verifier.cpp @@ -2192,12 +2192,12 @@ void Verifier::verifyStatepoint(const CallBase &Call) { "positive", Call); - const Value *Target = Call.getArgOperand(2); - auto *PT = dyn_cast(Target->getType()); - Assert(PT && PT->getPointerElementType()->isFunctionTy(), - "gc.statepoint callee must be of function pointer type", Call, Target); - FunctionType *TargetFuncType = - cast(PT->getPointerElementType()); + Type *TargetElemType = Call.getAttributes().getParamElementType(2); + Assert(TargetElemType, + "gc.statepoint callee argument must have elementtype attribute", Call); + FunctionType *TargetFuncType = dyn_cast(TargetElemType); + Assert(TargetFuncType, + "gc.statepoint callee elementtype must be function type", Call); const int NumCallArgs = cast(Call.getArgOperand(3))->getZExtValue(); Assert(NumCallArgs >= 0, @@ -5003,9 +5003,8 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) { Call.getArgOperand(0)); // Assert that result type matches wrapped callee. - const Value *Target = StatepointCall->getArgOperand(2); - auto *PT = cast(Target->getType()); - auto *TargetFuncType = cast(PT->getPointerElementType()); + auto *TargetFuncType = cast( + StatepointCall->getAttributes().getParamElementType(2)); Assert(Call.getType() == TargetFuncType->getReturnType(), "gc.result result type does not match wrapped callee", Call); break; diff --git a/llvm/test/Verifier/invalid-statepoint.ll b/llvm/test/Verifier/invalid-statepoint.ll index 7f2455bd2057..4e8f9815ab31 100644 --- a/llvm/test/Verifier/invalid-statepoint.ll +++ b/llvm/test/Verifier/invalid-statepoint.ll @@ -1,7 +1,5 @@ ; RUN: not opt -verify 2>&1 < %s | FileCheck %s -; CHECK: gc.statepoint mismatch in number of call args - declare zeroext i1 @return0i1() ; Function Attrs: nounwind @@ -10,7 +8,24 @@ declare token @llvm.experimental.gc.statepoint.p0f0i1f(i64, i32, i1 ()*, i32, i3 ; Function Attrs: nounwind declare i32 addrspace(1)* @llvm.experimental.gc.relocate.p1i32(token, i32, i32) #0 -define i32 addrspace(1)* @0(i32 addrspace(1)* %dparam) gc "statepoint-example" { +; CHECK: gc.statepoint callee argument must have elementtype attribute +define i32 addrspace(1)* @missing_elementtype(i32 addrspace(1)* %dparam) gc "statepoint-example" { + %a00 = load i32, i32 addrspace(1)* %dparam + %to0 = call token (i64, i32, i1 ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f0i1f(i64 0, i32 0, i1 ()* @return0i1, i32 9, i32 0, i2 0) ["gc-live" (i32 addrspace(1)* %dparam)] + %relocate = call i32 addrspace(1)* @llvm.experimental.gc.relocate.p1i32(token %to0, i32 0, i32 0) + ret i32 addrspace(1)* %relocate +} + +; CHECK: Attribute 'elementtype' type does not match parameter! +define i32 addrspace(1)* @elementtype_mismatch(i32 addrspace(1)* %dparam) gc "statepoint-example" { + %a00 = load i32, i32 addrspace(1)* %dparam + %to0 = call token (i64, i32, i1 ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f0i1f(i64 0, i32 0, i1 ()* elementtype(i32 ()) @return0i1, i32 9, i32 0, i2 0) ["gc-live" (i32 addrspace(1)* %dparam)] + %relocate = call i32 addrspace(1)* @llvm.experimental.gc.relocate.p1i32(token %to0, i32 0, i32 0) + ret i32 addrspace(1)* %relocate +} + +; CHECK: gc.statepoint mismatch in number of call args +define i32 addrspace(1)* @num_args_mismatch(i32 addrspace(1)* %dparam) gc "statepoint-example" { %a00 = load i32, i32 addrspace(1)* %dparam %to0 = call token (i64, i32, i1 ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f0i1f(i64 0, i32 0, i1 ()* elementtype(i1 ()) @return0i1, i32 9, i32 0, i2 0) ["gc-live" (i32 addrspace(1)* %dparam)] %relocate = call i32 addrspace(1)* @llvm.experimental.gc.relocate.p1i32(token %to0, i32 0, i32 0)