From 8eeb56d1333c846d7043fd6a5433782c20b81606 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 15 Apr 2019 22:51:54 +0000 Subject: [PATCH] Revert [Support] Add a test for recursive response file expansion This reverts r358451 (git commit c8497467edc5766ae81ffbde58159f8c6af50803) The test breaks a Windows buildbot: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17016/steps/test-check-all/logs/stdio llvm-svn: 358461 --- llvm/unittests/Support/CommandLineTest.cpp | 31 ---------------------- 1 file changed, 31 deletions(-) diff --git a/llvm/unittests/Support/CommandLineTest.cpp b/llvm/unittests/Support/CommandLineTest.cpp index 782a8169ec0b..fcbfd33e4c01 100644 --- a/llvm/unittests/Support/CommandLineTest.cpp +++ b/llvm/unittests/Support/CommandLineTest.cpp @@ -782,37 +782,6 @@ TEST(CommandLineTest, ResponseFiles) { llvm::sys::fs::remove(TestDir); } -TEST(CommandLineTest, RecursiveResponseFiles) { - SmallString<128> TestDir; - std::error_code EC = sys::fs::createUniqueDirectory("unittest", TestDir); - EXPECT_TRUE(!EC); - - SmallString<128> ResponseFilePath; - sys::path::append(ResponseFilePath, TestDir, "recursive.rsp"); - std::string ResponseFileRef = std::string("@") + ResponseFilePath.c_str(); - - std::ofstream ResponseFile(ResponseFilePath.str()); - EXPECT_TRUE(ResponseFile.is_open()); - ResponseFile << ResponseFileRef << "\n"; - ResponseFile << ResponseFileRef << "\n"; - ResponseFile.close(); - - // Ensure the recursive expansion terminates. - llvm::SmallVector Argv = {"test/test", - ResponseFileRef.c_str()}; - llvm::BumpPtrAllocator A; - llvm::StringSaver Saver(A); - bool Res = llvm::cl::ExpandResponseFiles( - Saver, llvm::cl::TokenizeGNUCommandLine, Argv, false, false); - EXPECT_FALSE(Res); - - // Ensure some expansion took place. - EXPECT_GT(Argv.size(), 2U); - EXPECT_STREQ(Argv[0], "test/test"); - for (size_t i = 1; i < Argv.size(); ++i) - EXPECT_STREQ(Argv[i], ResponseFileRef.c_str()); -} - TEST(CommandLineTest, SetDefautValue) { cl::ResetCommandLineParser();