maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[vscode] fix ubsan problem in the progress event reporter 

The error

UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/tools/lldb-vscode/ProgressEvent.cpp:89:64 in

was found in https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/1910/consoleFull#-15641370498254eaf0-7326-4999-85b0-388101f2d404

It turns out that we were not setting m_event_type when initializatin
and update case. The fix is very simple.

Differential Revision: https://reviews.llvm.org/D105832
This commit is contained in:
Walter Erquinigo 2021-07-12 11:46:36 -07:00
parent 7ed3e87825
commit 8ea1a630d6
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lldb/tools/lldb-vscode/ProgressEvent.cpp
View File

@ -47,6 +47,7 @@ ProgressEvent::ProgressEvent(uint64_t progress_id, Optional<StringRef> message,
m_percentage = 100;
} else {
// Update event
m_event_type = progressUpdate;
m_percentage = std::min(
(uint32_t)((double)completed / (double)total * 100.0), (uint32_t)99);
if (prev_event->Reported()) {