maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

scudo: Test realloc on increasing size buffers. 

While developing a change to the allocator I ended up breaking
realloc on secondary allocations with increasing sizes. That didn't
cause any of the unit tests to fail, which indicated that we're
missing some test coverage here. Add a unit test for that case.

Differential Revision: https://reviews.llvm.org/D102716
This commit is contained in:
Peter Collingbourne 2021-05-18 12:57:19 -07:00
parent 62eec33616
commit 8e93d10633
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
View File

@ -253,7 +253,28 @@ SCUDO_TYPED_TEST(ScudoCombinedTest, BlockReuse) {
EXPECT_TRUE(Found);
}
SCUDO_TYPED_TEST(ScudoCombinedTest, ReallocateLarge) {
SCUDO_TYPED_TEST(ScudoCombinedTest, ReallocateLargeIncreasing) {
auto *Allocator = this->Allocator.get();
// Reallocate a chunk all the way up to a secondary allocation, verifying that
// we preserve the data in the process.
scudo::uptr Size = 16;
void *P = Allocator->allocate(Size, Origin);
const char Marker = 0xab;
memset(P, Marker, Size);
while (Size < TypeParam::Primary::SizeClassMap::MaxSize * 4) {
void *NewP = Allocator->reallocate(P, Size * 2);
EXPECT_NE(NewP, nullptr);
for (scudo::uptr J = 0; J < Size; J++)
EXPECT_EQ((reinterpret_cast<char *>(NewP))[J], Marker);
memset(reinterpret_cast<char *>(NewP) + Size, Marker, Size);
Size *= 2U;
P = NewP;
}
Allocator->deallocate(P, Origin);
}
SCUDO_TYPED_TEST(ScudoCombinedTest, ReallocateLargeDecreasing) {
auto *Allocator = this->Allocator.get();
// Reallocate a large chunk all the way down to a byte, verifying that we