From 8e30e4b9b7d6e82aa1f1def07cfba78fef6c1084 Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Fri, 23 May 2014 18:35:44 +0000 Subject: [PATCH] [RuntimeDyld] Remove relocation bounds check introduced in r208375 (MachO only). We do all of our address arithmetic in 64-bit, and operations involving logically negative 32-bit offsets (actually represented as unsigned 64 bit ints) often overflow into higher bits. The overflow check could be preserved by casting to uint32 at the callsite for applyRelocationValue, but this would eliminate the value of the check. The right way to handle overflow in relocations is to make relocation processing target specific, and compute the values for RelocationEntry objects in the appropriate types (32-bit for 32-bit targets, 64-bit for 64-bit targets). This is coming as part of the cleanup I'm working on. This fixes another i386 regression test. llvm-svn: 209536 --- llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h index 6911f2f07aaa..08573eed5c87 100644 --- a/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h +++ b/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldMachO.h @@ -28,16 +28,13 @@ class RuntimeDyldMachO : public RuntimeDyldImpl { private: /// Write the least significant 'Size' bytes in 'Value' out at the address - /// pointed to by Addr. Check for overflow. + /// pointed to by Addr. bool applyRelocationValue(uint8_t *Addr, uint64_t Value, unsigned Size) { for (unsigned i = 0; i < Size; ++i) { *Addr++ = (uint8_t)Value; Value >>= 8; } - if (Value) // Catch overflow - return Error("Relocation out of range."); - return false; }