From 8e186df2f530078b65708d7440ee66f2ea00cdbc Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Sun, 13 Sep 2015 20:22:22 +0000 Subject: [PATCH] COFF: Corrected error message if a section failed to load. There is no sense to use Name in these lines as it is not initialized yet. Patch from Igor Kudrin! llvm-svn: 247531 --- lld/COFF/InputFiles.cpp | 4 ++-- lld/test/COFF/invalid-obj.test | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 lld/test/COFF/invalid-obj.test diff --git a/lld/COFF/InputFiles.cpp b/lld/COFF/InputFiles.cpp index a8537ec39650..df92c432b6a9 100644 --- a/lld/COFF/InputFiles.cpp +++ b/lld/COFF/InputFiles.cpp @@ -115,9 +115,9 @@ void ObjectFile::initializeChunks() { const coff_section *Sec; StringRef Name; std::error_code EC = COFFObj->getSection(I, Sec); - error(EC, Twine("getSection failed: ") + Name); + error(EC, Twine("getSection failed: #") + Twine(I)); EC = COFFObj->getSectionName(Sec, Name); - error(EC, Twine("getSectionName failed: ") + Name); + error(EC, Twine("getSectionName failed: #") + Twine(I)); if (Name == ".sxdata") { SXData = Sec; continue; diff --git a/lld/test/COFF/invalid-obj.test b/lld/test/COFF/invalid-obj.test new file mode 100644 index 000000000000..fd63f7874cc1 --- /dev/null +++ b/lld/test/COFF/invalid-obj.test @@ -0,0 +1,14 @@ +# RUN: yaml2obj %s > %t.obj +# RUN: not lld-link %t.obj 2>&1 | FileCheck %s + +# CHECK: getSectionName failed: #1: + +--- +header: + Machine: IMAGE_FILE_MACHINE_AMD64 + Characteristics: [] +sections: + - Name: '/1' + Characteristics: [] + SectionData: 00 +symbols: