maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[InlineCost] Check that function types match 

Retain the behavior we get without opaque pointers: A call to a
known function with different function type is considered an
indirect call.

This fixes the crash reported in https://reviews.llvm.org/D123300#3444772.
This commit is contained in:
Nikita Popov 2022-04-12 11:03:42 +02:00
parent dbd80d7d27
commit 8d5c8d57c6
2 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/Analysis/InlineCost.cpp
View File

@ -2136,14 +2136,14 @@ bool CallAnalyzer::visitCallBase(CallBase &Call) {
if (isa<CallInst>(Call) && cast<CallInst>(Call).cannotDuplicate())
ContainsNoDuplicateCall = true;
Value *Callee = Call.getCalledOperand();
Function *F = dyn_cast_or_null<Function>(Callee);
Function *F = Call.getCalledFunction();
bool IsIndirectCall = !F;
if (IsIndirectCall) {
// Check if this happens to be an indirect function call to a known function
// in this inline context. If not, we've done all we can.
Value *Callee = Call.getCalledOperand();
F = dyn_cast_or_null<Function>(SimplifiedValues.lookup(Callee));
if (!F) {
if (!F || F->getFunctionType() != Call.getFunctionType()) {
onCallArgumentSetup(Call);
if (!Call.onlyReadsMemory())

27
llvm/test/Transforms/Inline/opaque-ptr.ll Normal file
View File

@ -0,0 +1,27 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -S -inline < %s | FileCheck %s
define void @test(ptr %p1, ptr %p2) {
; CHECK-LABEL: @test(
; CHECK-NEXT: ret void
;
ret void
}
define void @test1() {
; CHECK-LABEL: @test1(
; CHECK-NEXT: [[CALL_I:%.*]] = call i32 @test(ptr null)
; CHECK-NEXT: ret void
;
call void @test2(ptr @test)
ret void
}
define void @test2(ptr %i) {
; CHECK-LABEL: @test2(
; CHECK-NEXT: [[CALL:%.*]] = call i32 [[I:%.*]](ptr null)
; CHECK-NEXT: ret void
;
%call = call i32 %i(ptr null)
ret void
}