maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Disable the second verification run when performing LTO through 

gold in NDEBUG mode.
Follow on patch for r247729 - LTO: Disable extra verify runs in release
builds.

llvm-svn: 247824
This commit is contained in:
Teresa Johnson 2015-09-16 18:06:45 +00:00
parent 62c01ff9ca
commit 8c8fe5a015
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
llvm/test/tools/gold/X86/disable-verify.ll Normal file
View File

@ -0,0 +1,25 @@
; RUN: llvm-as %s -o %t.o
; REQUIRES: asserts
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: --plugin-opt=disable-verify \
; RUN: --plugin-opt=-debug-pass=Arguments \
; RUN: -shared %t.o -o %t2.o 2>&1 | FileCheck %s
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: --plugin-opt=-debug-pass=Arguments \
; RUN: -shared %t.o -o %t2.o 2>&1 | FileCheck %s -check-prefix=VERIFY
target triple = "x86_64-unknown-linux-gnu"
; -disable-verify should disable output verification from the optimization
; pipeline.
; CHECK: Pass Arguments: {{.*}} -verify -ipsccp
; CHECK-NOT: -verify
; VERIFY: Pass Arguments: {{.*}} -verify {{.*}} -verify
define void @f() {
entry:
ret void
}

11
llvm/tools/gold/gold-plugin.cpp
View File

@ -94,6 +94,11 @@ namespace options {
static OutputType TheOutputType = OT_NORMAL;
static unsigned OptLevel = 2;
static unsigned Parallelism = 1;
#ifdef NDEBUG
static bool DisableVerify = true;
#else
static bool DisableVerify = false;
#endif
static std::string obj_path;
static std::string extra_library_path;
static std::string triple;
@ -134,6 +139,8 @@ namespace options {
} else if (opt.startswith("jobs=")) {
if (StringRef(opt_ + 5).getAsInteger(10, Parallelism))
message(LDPL_FATAL, "Invalid parallelism level: %s", opt_ + 5);
} else if (opt == "disable-verify") {
DisableVerify = true;
} else {
// Save this option to pass to the code generator.
// ParseCommandLineOptions() expects argv[0] to be program name. Lazily
@ -730,8 +737,10 @@ static void runLTOPasses(Module &M, TargetMachine &TM) {
PassManagerBuilder PMB;
PMB.LibraryInfo = new TargetLibraryInfoImpl(Triple(TM.getTargetTriple()));
PMB.Inliner = createFunctionInliningPass();
// Unconditionally verify input since it is not verified before this
// point and has unknown origin.
PMB.VerifyInput = true;
PMB.VerifyOutput = true;
PMB.VerifyOutput = !options::DisableVerify;
PMB.LoopVectorize = true;
PMB.SLPVectorize = true;
PMB.OptLevel = options::OptLevel;