maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[asan] do not instrument threadlocal globals, this is buggy 

llvm-svn: 145092
This commit is contained in:
Kostya Serebryany 2011-11-23 02:10:54 +00:00
parent 2d988f0f05
commit 8b5c7a56a3
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
View File

@ -455,6 +455,11 @@ bool AddressSanitizer::insertGlobalRedzones(Module &M) {
G->getLinkage() != GlobalVariable::PrivateLinkage && G->getLinkage() != GlobalVariable::PrivateLinkage &&
G->getLinkage() != GlobalVariable::InternalLinkage) G->getLinkage() != GlobalVariable::InternalLinkage)
continue; continue;
// Two problems with thread-locals:
// - The address of the main thread's copy can't be computed at link-time.
// - Need to poison all copies, not just the main thread's one.
if (G->isThreadLocal())
continue;
// For now, just ignore this Alloca if the alignment is large. // For now, just ignore this Alloca if the alignment is large.
if (G->getAlignment() > RedzoneSize) continue; if (G->getAlignment() > RedzoneSize) continue;
@ -787,6 +792,7 @@ void AddressSanitizer::PoisonStack(const ArrayRef<AllocaInst*> &AllocaVec,
// Workaround for bug 11395: we don't want to instrument stack in functions // Workaround for bug 11395: we don't want to instrument stack in functions
// with large assembly blobs (32-bit only), otherwise reg alloc may crash. // with large assembly blobs (32-bit only), otherwise reg alloc may crash.
// FIXME: remove once the bug 11395 is fixed.
bool AddressSanitizer::LooksLikeCodeInBug11395(Instruction *I) { bool AddressSanitizer::LooksLikeCodeInBug11395(Instruction *I) {
if (LongSize != 32) return false; if (LongSize != 32) return false;
CallInst *CI = dyn_cast<CallInst>(I); CallInst *CI = dyn_cast<CallInst>(I);

6
llvm/test/Instrumentation/AddressSanitizer/do-not-touch-threadlocal.ll Normal file
View File

@ -0,0 +1,6 @@
; RUN: opt < %s -asan -S | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
target triple = "x86_64-unknown-linux-gnu"
; no action should be taken for thread locals
@xxx = thread_local global i32 0, align 4
; CHECK-NOT: __asan_register_globals