maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ORC][RPC] Join server thread before checking condition in unit test. 

Otherwise we have a race on the sent-messages count.

llvm-svn: 371263
This commit is contained in:
Lang Hames 2019-09-06 21:55:43 +00:00
parent 7a7bba2895
commit 88cddb7a1c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/unittests/ExecutionEngine/Orc/RPCUtilsTest.cpp
View File

@ -214,6 +214,8 @@ TEST(DummyRPC, TestCallAsyncVoidBool) {
EXPECT_FALSE(!!Err) << "Client failed to handle response from void(bool)"; EXPECT_FALSE(!!Err) << "Client failed to handle response from void(bool)";
} }
ServerThread.join();
// The client should have made two calls to send: One implicit call to // The client should have made two calls to send: One implicit call to
// negotiate the VoidBool function key, and a second to make the VoidBool // negotiate the VoidBool function key, and a second to make the VoidBool
// call. // call.
@ -224,8 +226,6 @@ TEST(DummyRPC, TestCallAsyncVoidBool) {
// the negotiate call, and another to send the response to the VoidBool call. // the negotiate call, and another to send the response to the VoidBool call.
EXPECT_EQ(Channels.second->SendCalls, 2U) EXPECT_EQ(Channels.second->SendCalls, 2U)
<< "Expected two send calls to have been made by server"; << "Expected two send calls to have been made by server";
ServerThread.join();
} }
TEST(DummyRPC, TestCallAsyncIntInt) { TEST(DummyRPC, TestCallAsyncIntInt) {