maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init 

Summary:
Unnamed bitfields cannot be initialized.
Bitfields cannot be in-class initialized.

Reviewers: alexfh, hokein, aaron.ballman

Subscribers: Prazek, nemanjai, cfe-commits

Differential Revision: https://reviews.llvm.org/D26119

llvm-svn: 285752
This commit is contained in:
Malcolm Parsons 2016-11-01 21:26:53 +00:00
parent 5fc84a1828
commit 883ebacd78
2 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
View File

@ -358,7 +358,7 @@ void ProTypeMemberInitCheck::checkMissingMemberInitializer(
if (!F->hasInClassInitializer() &&
utils::type_traits::isTriviallyDefaultConstructible(F->getType(),
Context) &&
!isEmpty(Context, F->getType()))
!isEmpty(Context, F->getType()) && !F->isUnnamedBitfield())
FieldsToInit.insert(F);
});
if (FieldsToInit.empty())
@ -407,7 +407,9 @@ void ProTypeMemberInitCheck::checkMissingMemberInitializer(
SmallPtrSet<const FieldDecl *, 16> FieldsToFix;
forEachField(ClassDecl, FieldsToInit, true, [&](const FieldDecl *F) {
// Don't suggest fixes for enums because we don't know a good default.
if (!F->getType()->isEnumeralType())
// Don't suggest fixes for bitfields because in-class initialization is not
// possible.
if (!F->getType()->isEnumeralType() && !F->isBitField())
FieldsToFix.insert(F);
});
if (FieldsToFix.empty())

17
clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp
View File

@ -456,3 +456,20 @@ template <typename T> class NoCrash {
template <typename U> B(U u) {}
};
};
struct PositiveBitfieldMember {
PositiveBitfieldMember() {}
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor does not initialize these fields: F
unsigned F : 5;
};
struct NegativeUnnamedBitfieldMember {
NegativeUnnamedBitfieldMember() {}
unsigned : 5;
};
struct NegativeInitializedBitfieldMembers {
NegativeInitializedBitfieldMembers() : F(3) { G = 2; }
unsigned F : 5;
unsigned G : 5;
};