maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

SeparateConstOffsetFromGEP: Fix stack overflow in unreachable code 

ConstantOffsetExtractor::Find was infinitely recursing on the add
referencing itself.
This commit is contained in:
Matt Arsenault 2021-09-13 21:16:17 -04:00
parent fdd9761dd1
commit 88146230e1
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp
View File

@ -1164,6 +1164,9 @@ bool SeparateConstOffsetFromGEP::run(Function &F) {
DL = &F.getParent()->getDataLayout();
bool Changed = false;
for (BasicBlock &B : F) {
if (!DT->isReachableFromEntry(&B))
continue;
for (BasicBlock::iterator I = B.begin(), IE = B.end(); I != IE;)
if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(I++))
Changed |= splitGEP(GEP);

14
llvm/test/Transforms/SeparateConstOffsetFromGEP/crash-in-unreachable-code.ll Normal file
View File

@ -0,0 +1,14 @@
; RUN: opt -mtriple=amdgcn-amd-amdhsa -separate-const-offset-from-gep %s
@gv = external local_unnamed_addr addrspace(3) global [16 x i8], align 16
; The add referencing itself is illegal, except it's in an unreachable block.
define weak amdgpu_kernel void @foo() {
entry:
ret void
for.body28.i: ; preds = %for.body28.i
%arrayidx3389.i = getelementptr inbounds [16 x i8], [16 x i8] addrspace(3)* @gv, i32 0, i32 %inc38.7.i.1
%inc38.7.i.1 = add nuw nsw i32 %inc38.7.i.1, 16
br label %for.body28.i
}