maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[TargetLowering] Add support for non-uniform vectors to BuildSDIV 

This patch refactors the existing TargetLowering::BuildSDIV base implementation to support non-uniform constant vector denominators.

This is the last patch necessary to close PR36545

Differential Revision: https://reviews.llvm.org/D50765

llvm-svn: 339908
This commit is contained in:
Simon Pilgrim 2018-08-16 17:44:33 +00:00
parent bd5d71229d
commit 87d0039a45
2 changed files with 396 additions and 864 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
View File

@ -3510,7 +3510,9 @@ SDValue TargetLowering::BuildSDIV(SDNode *N, SelectionDAG &DAG,
SmallVectorImpl<SDNode *> &Created) const {
SDLoc dl(N);
EVT VT = N->getValueType(0);
EVT SVT = VT.getScalarType();
EVT ShVT = getShiftAmountTy(VT, DAG.getDataLayout());
EVT ShSVT = ShVT.getScalarType();
unsigned EltBits = VT.getScalarSizeInBits();
// Check to see if we can do this.
@ -3522,8 +3524,13 @@ SDValue TargetLowering::BuildSDIV(SDNode *N, SelectionDAG &DAG,
if (N->getFlags().hasExact())
return BuildExactSDIV(*this, N, dl, DAG, Created);
auto BuildSDIVPattern = [&](const APInt &Divisor, SDValue &MagicFactor,
SDValue &Factor, SDValue &Shift) {
SmallVector<SDValue, 16> MagicFactors, Factors, Shifts;
auto BuildSDIVPattern = [&](ConstantSDNode *C) {
if (C->isNullValue())
return false;
const APInt &Divisor = C->getAPIntValue();
APInt::ms magics = Divisor.magic();
int NumeratorFactor = 0;
@ -3534,22 +3541,29 @@ SDValue TargetLowering::BuildSDIV(SDNode *N, SelectionDAG &DAG,
else if (Divisor.isNegative() && magics.m.isStrictlyPositive())
NumeratorFactor = -1;
MagicFactor = DAG.getConstant(magics.m, dl, VT);
Factor = DAG.getConstant(NumeratorFactor, dl, VT);
Shift = DAG.getConstant(magics.s, dl, ShVT);
MagicFactors.push_back(DAG.getConstant(magics.m, dl, SVT));
Factors.push_back(DAG.getConstant(NumeratorFactor, dl, SVT));
Shifts.push_back(DAG.getConstant(magics.s, dl, ShSVT));
return true;
};
SDValue N0 = N->getOperand(0);
SDValue N1 = N->getOperand(1);
// TODO: Add non-uniform constant support.
ConstantSDNode *C = isConstOrConstSplat(N1);
if (!C || C->isNullValue())
// Collect the shifts / magic values from each element.
if (!ISD::matchUnaryPredicate(N1, BuildSDIVPattern))
return SDValue();
// Collect the shifts/magic values.
SDValue MagicFactor, Factor, Shift;
BuildSDIVPattern(C->getAPIntValue(), MagicFactor, Factor, Shift);
if (VT.isVector()) {
MagicFactor = DAG.getBuildVector(VT, dl, MagicFactors);
Factor = DAG.getBuildVector(VT, dl, Factors);
Shift = DAG.getBuildVector(ShVT, dl, Shifts);
} else {
MagicFactor = MagicFactors[0];
Factor = Factors[0];
Shift = Shifts[0];
}
// Multiply the numerator (operand 0) by the magic value
// FIXME: We should support doing a MUL in a wider type

1226
llvm/test/CodeGen/X86/combine-sdiv.ll
View File

File diff suppressed because it is too large Load Diff