maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb/Expression] Improve interpreter error message with a non-running target 

When trying to interpret an expression with a function call, if the
process hasn't been launched, the expression fails to be interpreted
and the user gets the following  error message:

```error: Can't run the expression locally```

This message doesn't explain why the expression failed to be
interpreted, that's why this patch improves the error message that is
displayed when trying to run an expression while no process is running.

rdar://11991708

Differential Revision: https://reviews.llvm.org/D72510

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
This commit is contained in:
Med Ismail Bennani 2020-01-14 12:12:57 +01:00
parent e27632c302
commit 877723b7ce
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py
View File

@ -35,7 +35,7 @@ class TestAllowJIT(TestBase):
"Set a breakpoint here", self.main_source_file)
frame = thread.GetFrameAtIndex(0)
# First make sure we can call the function with
interp = self.dbg.GetCommandInterpreter()
self.expect("expr --allow-jit 1 -- call_me(10)",
@ -43,8 +43,8 @@ class TestAllowJIT(TestBase):
# Now make sure it fails with the "can't IR interpret message" if allow-jit is false:
self.expect("expr --allow-jit 0 -- call_me(10)",
error=True,
substrs = ["Can't run the expression locally"])
substrs = ["Can't evaluate the expression without a running target"])
def expr_options_test(self):
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
"Set a breakpoint here", self.main_source_file)
@ -69,7 +69,7 @@ class TestAllowJIT(TestBase):
# Again use it and ensure we fail:
result = frame.EvaluateExpression("call_me(10)", options)
self.assertTrue(result.GetError().Fail(), "expression failed with no JIT")
self.assertTrue("Can't run the expression locally" in result.GetError().GetCString(), "Got right error")
self.assertTrue("Can't evaluate the expression without a running target" in result.GetError().GetCString(), "Got right error")
# Finally set the allow JIT value back to true and make sure that works:
options.SetAllowJIT(True)

5
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
View File

@ -1258,8 +1258,9 @@ lldb_private::Status ClangExpressionParser::PrepareForExecution(
interpret_error, interpret_function_calls);
if (!can_interpret && execution_policy == eExecutionPolicyNever) {
err.SetErrorStringWithFormat("Can't run the expression locally: %s",
interpret_error.AsCString());
err.SetErrorStringWithFormat(
"Can't evaluate the expression without a running target due to: %s",
interpret_error.AsCString());
return err;
}
}