maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MemoryDependence] Fix invariant group store 

Fix bug in MemoryDependence [and thus GVN] for invariant group.

Previously MemDep didn't verify that the store was storing into a
pointer rather than a store simply using a pointer.

Differential Revision: https://reviews.llvm.org/D98267
This commit is contained in:
William S. Moses 2021-03-09 11:55:19 -05:00
parent 75f3f77805
commit 875891a10d
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
View File

@ -344,7 +344,9 @@ MemoryDependenceResults::getInvariantGroupPointerDependency(LoadInst *LI,
// If we hit load/store with the same invariant.group metadata (and the
// same pointer operand) we can assume that value pointed by pointer
// operand didn't change.
if ((isa<LoadInst>(U) || isa<StoreInst>(U)) &&
if ((isa<LoadInst>(U) ||
(isa<StoreInst>(U) &&
cast<StoreInst>(U)->getPointerOperand() == Ptr)) &&
U->hasMetadata(LLVMContext::MD_invariant_group))
ClosestDependency = GetClosestDependency(ClosestDependency, U);
}

21
llvm/test/Transforms/GVN/storeinvgroup.ll Normal file
View File

@ -0,0 +1,21 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -gvn -S -o - < %s | FileCheck %s
define double @code(double* %a1) {
; CHECK-LABEL: @code(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[META:%.*]] = alloca double*, align 8
; CHECK-NEXT: store double 1.234500e+00, double* [[A1:%.*]], align 8
; CHECK-NEXT: store double* [[A1]], double** [[META]], align 8, !invariant.group !0
; CHECK-NEXT: ret double 1.234500e+00
;
entry:
%meta = alloca double*
store double 1.23450000e+00, double* %a1, align 8
store double* %a1, double** %meta, align 8, !invariant.group !0
%iload = load double, double* %a1, align 8, !invariant.group !1
ret double %iload
}
!0 = distinct !{}
!1 = distinct !{}