maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SVE] Mark VectorType::getNumElements() deprecated 

getNumElements() is being removed from base VectorType in
order to eliminate the class of bugs in which a scalable vector
is accidentally treated like a fixed length vector. Clients of
this function should either call getElementCount(), and handle
the case where getElementCount().isScalable() is true, or they can
cast to FixedVectorType and call getNumElements() if they are
sure that the vector has fixed width.

Deprecated VectorType functions will be removed after the LLVM
12 branch.

See: http://lists.llvm.org/pipermail/llvm-dev/2020-March/139811.html

Reviewed By: fpetrogalli

Differential Revision: https://reviews.llvm.org/D78127
This commit is contained in:
Christopher Tetreault 2020-08-31 14:38:18 -07:00
parent d563d7a731
commit 867de151a5
1 changed files with 22 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
llvm/include/llvm/IR/DerivedTypes.h
View File

@ -423,21 +423,11 @@ public:
/// Get the number of elements in this vector. It does not make sense to call
/// this function on a scalable vector, and this will be moved into
/// FixedVectorType in a future commit
unsigned getNumElements() const {
ElementCount EC = getElementCount();
#ifdef STRICT_FIXED_SIZE_VECTORS
assert(!EC.isScalable() &&
"Request for fixed number of elements from scalable vector");
return EC.getKnownMinValue();
#else
if (EC.isScalable())
WithColor::warning()
<< "The code that requested the fixed number of elements has made "
"the assumption that this vector is not scalable. This assumption "
"was not correct, and this may lead to broken code\n";
return EC.getKnownMinValue();
#endif
}
LLVM_ATTRIBUTE_DEPRECATED(
inline unsigned getNumElements() const,
"Calling this function via a base VectorType is deprecated. Either call "
"getElementCount() and handle the case where Scalable is true or cast to "
"FixedVectorType.");
Type *getElementType() const { return ContainedType; }
@ -540,6 +530,21 @@ public:
}
};
unsigned VectorType::getNumElements() const {
ElementCount EC = getElementCount();
#ifdef STRICT_FIXED_SIZE_VECTORS
assert(!EC.isScalable() &&
"Request for fixed number of elements from scalable vector");
#else
if (EC.isScalable())
WithColor::warning()
<< "The code that requested the fixed number of elements has made the "
"assumption that this vector is not scalable. This assumption was "
"not correct, and this may lead to broken code\n";
#endif
return EC.getKnownMinValue();
}
/// Class to represent fixed width SIMD vectors
class FixedVectorType : public VectorType {
protected:
@ -583,6 +588,8 @@ public:
static bool classof(const Type *T) {
return T->getTypeID() == FixedVectorTyID;
}
unsigned getNumElements() const { return ElementQuantity; }
};
/// Class to represent scalable SIMD vectors