maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[analyzer] Extract ControlDependencyHandler 

Differential Revision: https://reviews.llvm.org/D103677
This commit is contained in:
Valeriy Savchenko 2021-06-04 11:59:27 +03:00
parent bbebf38b73
commit 85f475c979
1 changed files with 30 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
View File

@ -2088,6 +2088,34 @@ public:
} }
}; };
class ControlDependencyHandler final : public ExpressionHandler {
public:
using ExpressionHandler::ExpressionHandler;
Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
const ExplodedNode *LVNode,
TrackingOptions Opts) override {
PathSensitiveBugReport &Report = getParentTracker().getReport();
// We only track expressions if we believe that they are important. Chances
// are good that control dependencies to the tracking point are also
// important because of this, let's explain why we believe control reached
// this point.
// TODO: Shouldn't we track control dependencies of every bug location,
// rather than only tracked expressions?
if (LVNode->getState()
->getAnalysisManager()
.getAnalyzerOptions()
.ShouldTrackConditions) {
Report.addVisitor<TrackControlDependencyCondBRVisitor>(
&getParentTracker(), InputNode);
return {/*FoundSomethingToTrack=*/true};
}
return {};
}
};
class DefaultExpressionHandler final : public ExpressionHandler { class DefaultExpressionHandler final : public ExpressionHandler {
public: public:
using ExpressionHandler::ExpressionHandler; using ExpressionHandler::ExpressionHandler;
@ -2100,20 +2128,6 @@ public:
PathSensitiveBugReport &Report = getParentTracker().getReport(); PathSensitiveBugReport &Report = getParentTracker().getReport();
Tracker::Result Result; Tracker::Result Result;
// We only track expressions if we believe that they are important. Chances
// are good that control dependencies to the tracking point are also
// important because of this, let's explain why we believe control reached
// this point.
// TODO: Shouldn't we track control dependencies of every bug location,
// rather than only tracked expressions?
if (LVState->getAnalysisManager()
.getAnalyzerOptions()
.ShouldTrackConditions) {
Report.addVisitor<TrackControlDependencyCondBRVisitor>(
&getParentTracker(), InputNode);
Result.FoundSomethingToTrack = true;
}
// The message send could be nil due to the receiver being nil. // The message send could be nil due to the receiver being nil.
// At this point in the path, the receiver should be live since we are at // At this point in the path, the receiver should be live since we are at
// the message send expr. If it is nil, start tracking it. // the message send expr. If it is nil, start tracking it.
@ -2293,7 +2307,8 @@ public:
Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) { Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) {
// Default expression handlers. // Default expression handlers.
addHighPriorityHandler<DefaultExpressionHandler>(); addLowPriorityHandler<ControlDependencyHandler>();
addLowPriorityHandler<DefaultExpressionHandler>();
addLowPriorityHandler<PRValueHandler>(); addLowPriorityHandler<PRValueHandler>();
// Default store handlers. // Default store handlers.
addHighPriorityHandler<DefaultStoreHandler>(); addHighPriorityHandler<DefaultStoreHandler>();