From 85f0e505e7683a7b944d2b2a63cfc576b6f8de59 Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Thu, 24 May 2018 06:09:28 +0000 Subject: [PATCH] Add Builtins.def support for fread and fwrite to ensure that -fno-builtin- works with them and test accordingly. llvm-svn: 333156 --- clang/include/clang/Basic/Builtins.def | 4 ++++ clang/test/CodeGen/libcalls-fno-builtin.c | 15 ++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/clang/include/clang/Basic/Builtins.def b/clang/include/clang/Basic/Builtins.def index da23f928949f..2126acb94133 100644 --- a/clang/include/clang/Basic/Builtins.def +++ b/clang/include/clang/Basic/Builtins.def @@ -847,6 +847,7 @@ LIBBUILTIN(memset, "v*v*iz", "f", "string.h", ALL_LANGUAGES) LIBBUILTIN(strerror, "c*i", "f", "string.h", ALL_LANGUAGES) LIBBUILTIN(strlen, "zcC*", "f", "string.h", ALL_LANGUAGES) // C99 stdio.h +// FIXME: This list is incomplete. LIBBUILTIN(printf, "icC*.", "fp:0:", "stdio.h", ALL_LANGUAGES) LIBBUILTIN(fprintf, "iP*cC*.", "fp:1:", "stdio.h", ALL_LANGUAGES) LIBBUILTIN(snprintf, "ic*zcC*.", "fp:2:", "stdio.h", ALL_LANGUAGES) @@ -861,6 +862,9 @@ LIBBUILTIN(sscanf, "icC*RcC*R.", "fs:1:", "stdio.h", ALL_LANGUAGES) LIBBUILTIN(vscanf, "icC*Ra", "fS:0:", "stdio.h", ALL_LANGUAGES) LIBBUILTIN(vfscanf, "iP*RcC*Ra", "fS:1:", "stdio.h", ALL_LANGUAGES) LIBBUILTIN(vsscanf, "icC*RcC*Ra", "fS:1:", "stdio.h", ALL_LANGUAGES) +LIBBUILTIN(fread, "zv*zzP*", "f", "stdio.h", ALL_LANGUAGES) +LIBBUILTIN(fwrite, "zvC*zzP*", "f", "stdio.h", ALL_LANGUAGES) + // C99 ctype.h LIBBUILTIN(isalnum, "ii", "fnU", "ctype.h", ALL_LANGUAGES) LIBBUILTIN(isalpha, "ii", "fnU", "ctype.h", ALL_LANGUAGES) diff --git a/clang/test/CodeGen/libcalls-fno-builtin.c b/clang/test/CodeGen/libcalls-fno-builtin.c index 8515e1d12333..14f361747c86 100644 --- a/clang/test/CodeGen/libcalls-fno-builtin.c +++ b/clang/test/CodeGen/libcalls-fno-builtin.c @@ -5,12 +5,14 @@ // RUN: -fno-builtin-strcpy -fno-builtin-stpcpy -fno-builtin-strncpy -fno-builtin-strlen \ // RUN: -fno-builtin-strpbrk -fno-builtin-strspn -fno-builtin-strtod -fno-builtin-strtof \ // RUN: -fno-builtin-strtold -fno-builtin-strtol -fno-builtin-strtoll -fno-builtin-strtoul \ -// RUN: -fno-builtin-strtoull -o - %s | FileCheck %s +// RUN: -fno-builtin-strtoull -fno-builtin-fread -fno-builtin-fwrite -o - %s | FileCheck %s // RUN: %clang_cc1 -S -O3 -fno-builtin -o - %s | FileCheck --check-prefix=ASM %s // RUN: %clang_cc1 -S -O3 -fno-builtin-ceil -o - %s | FileCheck --check-prefix=ASM-INDIV %s + // rdar://10551066 typedef __SIZE_TYPE__ size_t; +typedef struct FILE FILE; double ceil(double x); double copysign(double,double); @@ -36,6 +38,9 @@ long int strtol(const char *nptr, char **endptr, int base); long long int strtoll(const char *nptr, char **endptr, int base); unsigned long int strtoul(const char *nptr, char **endptr, int base); unsigned long long int strtoull(const char *nptr, char **endptr, int base); +size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream); +size_t fwrite(const void *ptr, size_t size, size_t nmemb, + FILE *stream); double t1(double x) { return ceil(x); } // CHECK-LABEL: t1 @@ -139,4 +144,12 @@ long int t24(char **x) { return strtoull("1234", x, 10); } // CHECK-LABEL: t24 // CHECK: call{{.*}}@strtoull{{.*}} [[ATTR]] +void t25(FILE *fp, int *buf) { + size_t x = fwrite(buf, sizeof(int), 10, fp); + size_t y = fread(buf, sizeof(int), 10, fp); +} +// CHECK-LABEL: t25 +// CHECK: call{{.*}}@fwrite{{.*}} [[ATTR]] +// CHECK: call{{.*}}@fread{{.*}} [[ATTR]] + // CHECK: [[ATTR]] = { nobuiltin }