diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 9114c0b5c199..dd5bfc4e880d 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -3206,6 +3206,25 @@ QualType Sema::CheckConditionalOperands(Expr *&Cond, Expr *&LHS, Expr *&RHS, ImpCastExprToType(RHS, compositeType); return compositeType; } + // Check Objective-C object pointer types and 'void *' + if (LHSTy->isVoidPointerType() && RHSTy->isObjCObjectPointerType()) { + QualType lhptee = LHSTy->getAsPointerType()->getPointeeType(); + QualType rhptee = RHSTy->getAsObjCObjectPointerType()->getPointeeType(); + QualType destPointee = lhptee.getQualifiedType(rhptee.getCVRQualifiers()); + QualType destType = Context.getPointerType(destPointee); + ImpCastExprToType(LHS, destType); // add qualifiers if necessary + ImpCastExprToType(RHS, destType); // promote to void* + return destType; + } + if (LHSTy->isObjCObjectPointerType() && RHSTy->isVoidPointerType()) { + QualType lhptee = LHSTy->getAsObjCObjectPointerType()->getPointeeType(); + QualType rhptee = RHSTy->getAsPointerType()->getPointeeType(); + QualType destPointee = rhptee.getQualifiedType(lhptee.getCVRQualifiers()); + QualType destType = Context.getPointerType(destPointee); + ImpCastExprToType(RHS, destType); // add qualifiers if necessary + ImpCastExprToType(LHS, destType); // promote to void* + return destType; + } // Check constraints for C object pointers types (C99 6.5.15p3,6). if (LHSTy->isPointerType() && RHSTy->isPointerType()) { // get the "pointed to" types diff --git a/clang/test/SemaObjC/conditional-expr-4.m b/clang/test/SemaObjC/conditional-expr-4.m index 7d50ba60750c..87209581534c 100644 --- a/clang/test/SemaObjC/conditional-expr-4.m +++ b/clang/test/SemaObjC/conditional-expr-4.m @@ -1,5 +1,4 @@ -// RUN: clang-cc -fsyntax-only %s -// XFAIL +// RUN: clang-cc -fsyntax-only -verify %s // #define nil ((void*) 0) @@ -26,6 +25,11 @@ A *f1_a(int cond, A *a) { return cond ? a : nil; } +void *f1_const_a(int x, void *p, const A * q) { + void *r = x ? p : q; // expected-warning{{initializing 'void const *' discards qualifiers, expected 'void *'}} + return r; +} + // Check interaction with qualified id @protocol P0 @end @@ -48,9 +52,7 @@ id f3(int cond, id a) { @end int f5(int cond, id a, id b) { - // This should result in something with id type, currently. This is - // almost certainly wrong and should be fixed. - return (cond ? a : b).x; // expected-error {{member reference base type ('id') is not a structure or union}} + return (cond ? a : b).x; } int f5_a(int cond, A *a, A *b) { return (cond ? a : b).x; @@ -61,7 +63,7 @@ int f5_b(int cond, A *a, B *b) { int f6(int cond, id a, void *b) { // This should result in something with id type, currently. - return (cond ? a : b).x; // expected-error {{member reference base type ('id') is not a structure or union}} + return (cond ? a : b).x; // expected-error {{member reference base type 'void *' is not a structure or union}} } int f7(int cond, id a) { @@ -69,10 +71,10 @@ int f7(int cond, id a) { } int f8(int cond, id a, A *b) { - // GCC regards this as a warning (comparison of distinct Objective-C types lacks a cast) - return a == b; // expected-error {{invalid operands to binary expression}} + return a == b; // expected-warning {{comparison of distinct pointer types ('id' and 'A *')}} } int f9(int cond, id a, A *b) { - return (cond ? a : b).x; // expected-error {{incompatible operand types}} + return (cond ? a : b).x; // expected-warning {{incompatible operand types ('id' and 'A *')}} \ + expected-error {{property 'x' not found on object of type 'id'}} }