maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[AsmPrinter] __patchable_function_entries: Set SHF_LINK_ORDER for binutils 2.36 and above 

This matches GCC behavior when the configure-time binutils is new. GNU ld<2.36
did not support mixed SHF_LINK_ORDER and non-SHF_LINK_ORDER sections in an
output section, so we conservatively disable SHF_LINK_ORDER for <2.36.
This commit is contained in:
Fangrui Song 2021-02-05 19:53:06 -08:00
parent 801d9cc7b9
commit 853a264916
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
View File

@ -3464,9 +3464,9 @@ void AsmPrinter::emitPatchableFunctionEntries() {
const MCSymbolELF *LinkedToSym = nullptr;
StringRef GroupName;
// GNU as < 2.35 did not support section flag 'o'. Use SHF_LINK_ORDER only
// if we are using the integrated assembler.
if (MAI->useIntegratedAssembler()) {
// GNU as < 2.35 did not support section flag 'o'. GNU ld < 2.36 did not
// support mixed SHF_LINK_ORDER and non-SHF_LINK_ORDER sections.
if (MAI->useIntegratedAssembler() || MAI->binutilsIsAtLeast(2, 36)) {
Flags |= ELF::SHF_LINK_ORDER;
if (F.hasComdat()) {
Flags |= ELF::SHF_GROUP;

6
llvm/test/CodeGen/AArch64/patchable-function-entry.ll
View File

@ -1,8 +1,10 @@
; RUN: llc -mtriple=aarch64 %s -o - | FileCheck %s
; RUN: llc -mtriple=aarch64 -function-sections %s -o - | FileCheck %s
; RUN: llc -mtriple=aarch64 -no-integrated-as %s -o - | FileCheck --check-prefix=NOLINK %s
; RUN: llc -mtriple=aarch64 -function-sections %s -o - | FileCheck %s
; RUN: llc -mtriple=aarch64 -no-integrated-as -binutils-version=2.35 %s -o - | FileCheck --check-prefix=NOLINK %s
; RUN: llc -mtriple=aarch64 -no-integrated-as -binutils-version=2.36 %s -o - | FileCheck %s
;; GNU as < 2.35 did not support section flag 'o'.
;; GNU ld < 2.36 did not support mixed SHF_LINK_ORDER and non-SHF_LINK_ORDER sections.
; NOLINK-NOT: "awo"
define i32 @f0() "patchable-function-entry"="0" {