maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb] Fix broken bad-address-breakpoint test 

After changing the "fallback" behavior when a user sets a breakpoint
without specifying a module the bad-address-breakpoint test case failed
incorrectly. This patch updates that test case in order to more
thoroughly discover an illegal address and use that as the means for
testing whether a breakpoint set at an illegal address fails to resolve.

Differential revision: https://reviews.llvm.org/D126109
This commit is contained in:
Will Hawkins 2022-05-26 12:14:22 -07:00 committed by Jonas Devlieghere
parent 48ca3a5ebb
commit 84b9985f5f
No known key found for this signature in database
GPG Key ID: 49CC0BD90FDEED4D
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py
View File

@ -27,14 +27,26 @@ class BadAddressBreakpointTestCase(TestBase):
"Set a breakpoint here",
lldb.SBFileSpec("main.c"))
# Now see if we can read from 0. If I can't do that, I don't
# have a good way to know what an illegal address is...
error = lldb.SBError()
ptr = process.ReadPointerFromMemory(0x0, error)
if not error.Success():
bkpt = target.BreakpointCreateByAddress(0x0)
# illegal_address will hold (optionally) an address that, if
# used as a breakpoint, will generate an unresolved breakpoint.
illegal_address = None
# Walk through all the memory regions in the process and
# find an address that is invalid.
regions = process.GetMemoryRegions()
for region_idx in range(regions.GetSize()):
region = lldb.SBMemoryRegionInfo()
regions.GetMemoryRegionAtIndex(region_idx, region)
if illegal_address == None or \
region.GetRegionEnd() > illegal_address:
illegal_address = region.GetRegionEnd()
if illegal_address is not None:
# Now, set a breakpoint at the address we know is illegal.
bkpt = target.BreakpointCreateByAddress(illegal_address)
# Verify that breakpoint is not resolved.
for bp_loc in bkpt:
self.assertEquals(bp_loc.IsResolved(), False)
else: