maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Add a template helper to avoid multiple switches over the ELF kind. NFC. 

llvm-svn: 246823
This commit is contained in:
Rafael Espindola 2015-09-04 00:09:43 +00:00
parent 3921fc7de7
commit 824d1a975f
2 changed files with 22 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
lld/ELF/SymbolTable.cpp
View File

@ -32,51 +32,41 @@ template <class ELFT> void SymbolTable::init() {
Undefined<ELFT>("_start", Undefined<ELFT>::Synthetic));
}
void SymbolTable::addELFFile(ELFFileBase *File) {
template <class ELFT> void SymbolTable::addELFFile(ELFFileBase *File) {
if (const ELFFileBase *Old = getFirstELF()) {
if (!Old->isCompatibleWith(*File))
error(Twine(Old->getName() + " is incompatible with " + File->getName()));
} else {
switch (File->getELFKind()) {
case ELF32LEKind:
init<ELF32LE>();
break;
case ELF32BEKind:
init<ELF32BE>();
break;
case ELF64LEKind:
init<ELF64LE>();
break;
case ELF64BEKind:
init<ELF64BE>();
break;
}
init<ELFT>();
}
if (auto *O = dyn_cast<ObjectFileBase>(File)) {
ObjectFiles.emplace_back(O);
for (SymbolBody *Body : O->getSymbols()) {
switch (File->getELFKind()) {
case ELF32LEKind:
resolve<ELF32LE>(Body);
break;
case ELF32BEKind:
resolve<ELF32BE>(Body);
break;
case ELF64LEKind:
resolve<ELF64LE>(Body);
break;
case ELF64BEKind:
resolve<ELF64BE>(Body);
break;
}
}
for (SymbolBody *Body : O->getSymbols())
resolve<ELFT>(Body);
}
if (auto *S = dyn_cast<SharedFileBase>(File))
SharedFiles.emplace_back(S);
}
void SymbolTable::addELFFile(ELFFileBase *File) {
switch (File->getELFKind()) {
case ELF32LEKind:
addELFFile<ELF32LE>(File);
break;
case ELF32BEKind:
addELFFile<ELF32BE>(File);
break;
case ELF64LEKind:
addELFFile<ELF64LE>(File);
break;
case ELF64BEKind:
addELFFile<ELF64BE>(File);
break;
}
}
void SymbolTable::reportRemainingUndefines() {
for (auto &I : Symtab) {
SymbolBody *Body = I.second->Body;

1
lld/ELF/SymbolTable.h
View File

@ -54,6 +54,7 @@ public:
}
private:
template <class ELFT> void addELFFile(ELFFileBase *File);
void addELFFile(ELFFileBase *File);
template <class ELFT> void init();