maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc++][format] Use a helper constant. 

The code accidentally uses a hard-coded value. Use a constant to make
sure the same value is used at both places.
This commit is contained in:
Mark de Wever 2022-04-07 19:22:14 +02:00
parent 4048aad85a
commit 82427685ea
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libcxx/include/__format/formatter_pointer.h
View File

@ -46,10 +46,12 @@ public:
// but that code isn't public. Making that code public requires some // but that code isn't public. Making that code public requires some
// refactoring. // refactoring.
// TODO FMT Remove code duplication. // TODO FMT Remove code duplication.
char __buffer[2 + 2 * sizeof(uintptr_t)]; constexpr size_t __max_hex_digits = 2 * sizeof(uintptr_t);
char __buffer[2 + __max_hex_digits];
__buffer[0] = '0'; __buffer[0] = '0';
__buffer[1] = 'x'; __buffer[1] = 'x';
char* __last = __to_buffer(__buffer + 2, _VSTD::end(__buffer), reinterpret_cast<uintptr_t>(__ptr), 16); char* __last =
__to_buffer(__buffer + 2, _VSTD::end(__buffer), reinterpret_cast<uintptr_t>(__ptr), __max_hex_digits);
unsigned __size = __last - __buffer; unsigned __size = __last - __buffer;
if (__size >= this->__width) if (__size >= this->__width)