[RenderScript] reflow/reword some comments and normalize names

Pay more attention to comment alignement (Since _The Great Reformat_ (a015ff50)
comments are no longer properly aligned) and variable naming conventions.

- Manually reflow and cleanup comments and array literals
- Be more economical with our naming conventions
- Be internally consistent with regard to local variable/member function
  naming

llvm-svn: 283335

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.h

@@ -27,13 +27,11 @@
 #include "RenderScriptx86ABIFixups.h"
 
 // RenderScriptRuntimeModulePass is a simple llvm::ModulesPass that is used
-// during expression evaluation to apply
-// RenderScript-specific fixes for expression evaluation.
-// In particular this is used to make expression IR conformant with the ABI
-// generated by the slang frontend. This
-// ModulePass is executed in ClangExpressionParser::PrepareForExecution whenever
-// an expression's DWARF language is
-// eLanguageTypeExtRenderscript
+// during expression evaluation to apply RenderScript-specific fixes for
+// expression evaluation. In particular this is used to make expression IR
+// conformant with the ABI generated by the slang frontend. This ModulePass is
+// executed in ClangExpressionParser::PrepareForExecution whenever an
+// expression's DWARF language is eLanguageTypeExtRenderscript
 
 class RenderScriptRuntimeModulePass : public llvm::ModulePass {
 public:

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h

@@ -50,13 +50,13 @@ struct RSCoordinate {
   }
 };
 
-// Breakpoint Resolvers decide where a breakpoint is placed,
-// so having our own allows us to limit the search scope to RS kernel modules.
-// As well as check for .expand kernels as a fallback.
+// Breakpoint Resolvers decide where a breakpoint is placed, so having our own
+// allows us to limit the search scope to RS kernel modules. As well as check
+// for .expand kernels as a fallback.
 class RSBreakpointResolver : public BreakpointResolver {
 public:
-  RSBreakpointResolver(Breakpoint *bkpt, ConstString name)
-      : BreakpointResolver(bkpt, BreakpointResolver::NameResolver),
+  RSBreakpointResolver(Breakpoint *bp, ConstString name)
+      : BreakpointResolver(bp, BreakpointResolver::NameResolver),
         m_kernel_name(name) {}
 
   void GetDescription(Stream *strm) override {
@@ -224,7 +224,7 @@ public:
 
   bool CouldHaveDynamicValue(ValueObject &in_value) override;
 
-  lldb::BreakpointResolverSP CreateExceptionResolver(Breakpoint *bkpt,
+  lldb::BreakpointResolverSP CreateExceptionResolver(Breakpoint *bp,
                                                      bool catch_bp,
                                                      bool throw_bp) override;
 
@@ -287,7 +287,7 @@ protected:
 
   void LoadRuntimeHooks(lldb::ModuleSP module, ModuleKind kind);
 
-  bool RefreshAllocation(AllocationDetails *allocation, StackFrame *frame_ptr);
+  bool RefreshAllocation(AllocationDetails *alloc, StackFrame *frame_ptr);
 
   bool EvalRSExpression(const char *expression, StackFrame *frame_ptr,
                         uint64_t *result);
@@ -370,7 +370,7 @@ private:
 
   AllocationDetails *FindAllocByID(Stream &strm, const uint32_t alloc_id);
 
-  std::shared_ptr<uint8_t> GetAllocationData(AllocationDetails *allocation,
+  std::shared_ptr<uint8_t> GetAllocationData(AllocationDetails *alloc,
                                              StackFrame *frame_ptr);
 
   void SetElementSize(Element &elem);
@@ -391,23 +391,22 @@ private:
   // Helper functions for jitting the runtime
   //
 
-  bool JITDataPointer(AllocationDetails *allocation, StackFrame *frame_ptr,
+  bool JITDataPointer(AllocationDetails *alloc, StackFrame *frame_ptr,
                       uint32_t x = 0, uint32_t y = 0, uint32_t z = 0);
 
-  bool JITTypePointer(AllocationDetails *allocation, StackFrame *frame_ptr);
+  bool JITTypePointer(AllocationDetails *alloc, StackFrame *frame_ptr);
 
-  bool JITTypePacked(AllocationDetails *allocation, StackFrame *frame_ptr);
+  bool JITTypePacked(AllocationDetails *alloc, StackFrame *frame_ptr);
 
   bool JITElementPacked(Element &elem, const lldb::addr_t context,
                         StackFrame *frame_ptr);
 
-  bool JITAllocationSize(AllocationDetails *allocation, StackFrame *frame_ptr);
+  bool JITAllocationSize(AllocationDetails *alloc, StackFrame *frame_ptr);
 
   bool JITSubelements(Element &elem, const lldb::addr_t context,
                       StackFrame *frame_ptr);
 
-  bool JITAllocationStride(AllocationDetails *allocation,
-                           StackFrame *frame_ptr);
+  bool JITAllocationStride(AllocationDetails *alloc, StackFrame *frame_ptr);
 
   // Search for a script detail object using a target address.
   // If a script does not currently exist this function will return nullptr.

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp

@@ -267,8 +267,8 @@ bool fixupRSAllocationStructByValCalls(llvm::Module &module) {
   // for all called function decls
   for (auto func : rs_functions) {
     // inspect all of the arguments in the call
-    llvm::SymbolTableList<llvm::Argument> &argList = func->getArgumentList();
-    for (auto &arg : argList) {
+    llvm::SymbolTableList<llvm::Argument> &arg_list = func->getArgumentList();
+    for (auto &arg : arg_list) {
       if (arg.hasByValAttr()) {
         arg.removeAttr(attr_byval);
         changed = true;