maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB][GUI] Check fields validity in actions 

This patch adds a virtual method HasError to fields, it can be
overridden by fields that have errors. Additionally, a form method
CheckFieldsValidity was added to be called by actions that expects all
the field to be valid.

Differential Revision: https://reviews.llvm.org/D106459
This commit is contained in:
Omar Emara 2021-07-23 18:02:24 -07:00 committed by Greg Clayton
parent e160b3987e
commit 80ac12b70b
1 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
lldb/source/Core/IOHandlerCursesGUI.cpp
View File

@ -1061,6 +1061,9 @@ public:
// Select the last element in the field if multiple elements exists.
virtual void FieldDelegateSelectLastElement() { return; }
// Returns true if the field has an error, false otherwise.
virtual bool FieldDelegateHasError() { return false; }
bool FieldDelegateIsVisible() { return m_is_visible; }
void FieldDelegateHide() { m_is_visible = false; }
@ -1098,7 +1101,7 @@ public:
// field and an optional line for an error if it exists.
int FieldDelegateGetHeight() override {
int height = GetFieldHeight();
if (HasError())
if (FieldDelegateHasError())
height++;
return height;
}
@ -1138,7 +1141,7 @@ public:
}
void DrawError(SubPad &surface) {
if (!HasError())
if (!FieldDelegateHasError())
return;
surface.MoveCursor(0, 0);
surface.AttributeOn(COLOR_PAIR(RedOnBlack));
@ -1239,6 +1242,8 @@ public:
return eKeyNotHandled;
}
bool FieldDelegateHasError() override { return !m_error.empty(); }
void FieldDelegateExitCallback() override {
if (!IsSpecified() && m_required)
SetError("This field is required!");
@ -1246,8 +1251,6 @@ public:
bool IsSpecified() { return !m_content.empty(); }
bool HasError() { return !m_error.empty(); }
void ClearError() { m_error.clear(); }
const std::string &GetError() { return m_error; }
@ -1920,6 +1923,19 @@ public:
void SetError(const char *error) { m_error = error; }
// If all fields are valid, true is returned. Otherwise, an error message is
// set and false is returned. This method is usually called at the start of an
// action that requires valid fields.
bool CheckFieldsValidity() {
for (int i = 0; i < GetNumberOfFields(); i++) {
if (GetField(i)->FieldDelegateHasError()) {
SetError("Some fields are invalid!");
return false;
}
}
return true;
}
// Factory methods to create and add fields of specific types.
TextFieldDelegate *AddTextField(const char *label, const char *content,
@ -2535,6 +2551,10 @@ public:
void Attach(Window &window) {
ClearError();
bool all_fields_are_valid = CheckFieldsValidity();
if (!all_fields_are_valid)
return;
bool process_is_running = StopRunningProcess();
if (process_is_running)
return;