maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

avoid redundant lookups in BBExecutable, and make it a SmallPtrSet. 

llvm-svn: 85790
This commit is contained in:
Chris Lattner 2009-11-02 06:11:23 +00:00
parent e77c9aa04a
commit 809aee2f40
1 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
llvm/lib/Transforms/Scalar/SCCP.cpp
View File

@ -37,6 +37,7 @@
#include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/DenseSet.h" #include "llvm/ADT/DenseSet.h"
#include "llvm/ADT/PointerIntPair.h" #include "llvm/ADT/PointerIntPair.h"
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/Statistic.h" #include "llvm/ADT/Statistic.h"
#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/STLExtras.h"
@ -156,7 +157,7 @@ namespace {
/// ///
class SCCPSolver : public InstVisitor<SCCPSolver> { class SCCPSolver : public InstVisitor<SCCPSolver> {
const TargetData *TD; const TargetData *TD;
DenseSet<BasicBlock*> BBExecutable;// The basic blocks that are executable SmallPtrSet<BasicBlock*, 8> BBExecutable;// The BBs that are executable.
DenseMap<Value*, LatticeVal> ValueState; // The state each value is in. DenseMap<Value*, LatticeVal> ValueState; // The state each value is in.
/// GlobalValue - If we are tracking any values for the contents of a global /// GlobalValue - If we are tracking any values for the contents of a global
@ -200,10 +201,13 @@ public:
/// MarkBlockExecutable - This method can be used by clients to mark all of /// MarkBlockExecutable - This method can be used by clients to mark all of
/// the blocks that are known to be intrinsically live in the processed unit. /// the blocks that are known to be intrinsically live in the processed unit.
void MarkBlockExecutable(BasicBlock *BB) { ///
/// This returns true if the block was not considered live before.
bool MarkBlockExecutable(BasicBlock *BB) {
if (!BBExecutable.insert(BB)) return false;
DEBUG(errs() << "Marking Block Executable: " << BB->getName() << "\n"); DEBUG(errs() << "Marking Block Executable: " << BB->getName() << "\n");
BBExecutable.insert(BB); // Basic block is executable!
BBWorkList.push_back(BB); // Add the block to the work list! BBWorkList.push_back(BB); // Add the block to the work list!
return true;
} }
/// TrackValueOfGlobalVariable - Clients can use this method to /// TrackValueOfGlobalVariable - Clients can use this method to
@ -348,18 +352,17 @@ private:
if (!KnownFeasibleEdges.insert(Edge(Source, Dest)).second) if (!KnownFeasibleEdges.insert(Edge(Source, Dest)).second)
return; // This edge is already known to be executable! return; // This edge is already known to be executable!
if (BBExecutable.count(Dest)) { if (!MarkBlockExecutable(Dest)) {
// If the destination is already executable, we just made an *edge*
// feasible that wasn't before. Revisit the PHI nodes in the block
// because they have potentially new operands.
DEBUG(errs() << "Marking Edge Executable: " << Source->getName() DEBUG(errs() << "Marking Edge Executable: " << Source->getName()
<< " -> " << Dest->getName() << "\n"); << " -> " << Dest->getName() << "\n");
// The destination is already executable, but we just made an edge PHINode *PN;
// feasible that wasn't before. Revisit the PHI nodes in the block for (BasicBlock::iterator I = Dest->begin();
// because they have potentially new operands. (PN = dyn_cast<PHINode>(I)); ++I)
for (BasicBlock::iterator I = Dest->begin(); isa<PHINode>(I); ++I) visitPHINode(*PN);
visitPHINode(*cast<PHINode>(I));
} else {
MarkBlockExecutable(Dest);
} }
} }
@ -1229,7 +1232,6 @@ CallOverdefined:
// Finally, if this is the first call to the function hit, mark its entry // Finally, if this is the first call to the function hit, mark its entry
// block executable. // block executable.
if (!BBExecutable.count(F->begin()))
MarkBlockExecutable(F->begin()); MarkBlockExecutable(F->begin());
// Propagate information from this call site into the callee. // Propagate information from this call site into the callee.