maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

tsan: don't unroll memory access loop in debug mode 

MemoryAccess function consumes ~4K of stack in debug mode,
in significant part due to the unrolled loop.
And gtest gives only 4K of stack to death test
threads, which causes stack overflows in debug mode.

llvm-svn: 226644
This commit is contained in:
Dmitry Vyukov 2015-01-21 08:09:13 +00:00
parent 8a1887f1f1
commit 8070ac6bd6
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
compiler-rt/lib/tsan/rtl/tsan_rtl.cc
View File

@ -565,6 +565,16 @@ void MemoryAccessImpl1(ThreadState *thr, uptr addr,
Shadow old(0);
// It release mode we manually unroll the loop,
// because empirically gcc generates better code this way.
// However, we can't afford unrolling in debug mode, because the function
// consumes almost 4K of stack. Gtest gives only 4K of stack to death test
// threads, which is not enough for the unrolled loop.
#if SANITIZER_DEBUG
for (int idx = 0; idx < 4; idx++) {
#include "tsan_update_shadow_word_inl.h"
}
#else
int idx = 0;
#include "tsan_update_shadow_word_inl.h"
idx = 1;
@ -573,6 +583,7 @@ void MemoryAccessImpl1(ThreadState *thr, uptr addr,
#include "tsan_update_shadow_word_inl.h"
idx = 3;
#include "tsan_update_shadow_word_inl.h"
#endif
// we did not find any races and had already stored
// the current access info, so we are done