NFC: Document MSVC getters on Triple

Summary:
Document the differences between the isKnownWindowsMSVC() and isWindowsMSVC() methods on Triple.

Also removed the '\brief' Doxygen annotations - now that 'AUTOBRIEF' is set to on, they are unnecessary.

Subscribers: jfb, tberghammer, danalbert, srhines, dschuff

Differential Revision: http://reviews.llvm.org/D14110

llvm-svn: 253159
This commit is contained in:
Dylan McKay 2015-11-15 05:43:11 +00:00
parent 2512241b31
commit 80321b8cc2
1 changed files with 21 additions and 19 deletions

View File

@ -213,7 +213,7 @@ public:
/// @name Constructors /// @name Constructors
/// @{ /// @{
/// \brief Default constructor is the same as an empty string and leaves all /// Default constructor is the same as an empty string and leaves all
/// triple fields unknown. /// triple fields unknown.
Triple() : Data(), Arch(), Vendor(), OS(), Environment(), ObjectFormat() {} Triple() : Data(), Arch(), Vendor(), OS(), Environment(), ObjectFormat() {}
@ -239,7 +239,7 @@ public:
/// common case in which otherwise valid components are in the wrong order. /// common case in which otherwise valid components are in the wrong order.
static std::string normalize(StringRef Str); static std::string normalize(StringRef Str);
/// \brief Return the normalized form of this triple's string. /// Return the normalized form of this triple's string.
std::string normalize() const { return normalize(Data); } std::string normalize() const { return normalize(Data); }
/// @} /// @}
@ -267,7 +267,7 @@ public:
/// getEnvironment - Get the parsed environment type of this triple. /// getEnvironment - Get the parsed environment type of this triple.
EnvironmentType getEnvironment() const { return Environment; } EnvironmentType getEnvironment() const { return Environment; }
/// \brief Parse the version number from the OS name component of the /// Parse the version number from the OS name component of the
/// triple, if present. /// triple, if present.
/// ///
/// For example, "fooos1.2.3" would return (1, 2, 3). /// For example, "fooos1.2.3" would return (1, 2, 3).
@ -344,7 +344,7 @@ public:
/// @name Convenience Predicates /// @name Convenience Predicates
/// @{ /// @{
/// \brief Test whether the architecture is 64-bit /// Test whether the architecture is 64-bit
/// ///
/// Note that this tests for 64-bit pointer width, and nothing else. Note /// Note that this tests for 64-bit pointer width, and nothing else. Note
/// that we intentionally expose only three predicates, 64-bit, 32-bit, and /// that we intentionally expose only three predicates, 64-bit, 32-bit, and
@ -353,12 +353,12 @@ public:
/// system is provided. /// system is provided.
bool isArch64Bit() const; bool isArch64Bit() const;
/// \brief Test whether the architecture is 32-bit /// Test whether the architecture is 32-bit
/// ///
/// Note that this tests for 32-bit pointer width, and nothing else. /// Note that this tests for 32-bit pointer width, and nothing else.
bool isArch32Bit() const; bool isArch32Bit() const;
/// \brief Test whether the architecture is 16-bit /// Test whether the architecture is 16-bit
/// ///
/// Note that this tests for 16-bit pointer width, and nothing else. /// Note that this tests for 16-bit pointer width, and nothing else.
bool isArch16Bit() const; bool isArch16Bit() const;
@ -458,12 +458,14 @@ public:
return getOS() == Triple::ELFIAMCU; return getOS() == Triple::ELFIAMCU;
} }
/// Checks if the environment could be MSVC.
bool isWindowsMSVCEnvironment() const { bool isWindowsMSVCEnvironment() const {
return getOS() == Triple::Win32 && return getOS() == Triple::Win32 &&
(getEnvironment() == Triple::UnknownEnvironment || (getEnvironment() == Triple::UnknownEnvironment ||
getEnvironment() == Triple::MSVC); getEnvironment() == Triple::MSVC);
} }
/// Checks if the environment is MSVC.
bool isKnownWindowsMSVCEnvironment() const { bool isKnownWindowsMSVCEnvironment() const {
return getOS() == Triple::Win32 && getEnvironment() == Triple::MSVC; return getOS() == Triple::Win32 && getEnvironment() == Triple::MSVC;
} }
@ -484,61 +486,61 @@ public:
return getOS() == Triple::Win32 && getEnvironment() == Triple::GNU; return getOS() == Triple::Win32 && getEnvironment() == Triple::GNU;
} }
/// \brief Tests for either Cygwin or MinGW OS /// Tests for either Cygwin or MinGW OS
bool isOSCygMing() const { bool isOSCygMing() const {
return isWindowsCygwinEnvironment() || isWindowsGNUEnvironment(); return isWindowsCygwinEnvironment() || isWindowsGNUEnvironment();
} }
/// \brief Is this a "Windows" OS targeting a "MSVCRT.dll" environment. /// Is this a "Windows" OS targeting a "MSVCRT.dll" environment.
bool isOSMSVCRT() const { bool isOSMSVCRT() const {
return isWindowsMSVCEnvironment() || isWindowsGNUEnvironment() || return isWindowsMSVCEnvironment() || isWindowsGNUEnvironment() ||
isWindowsItaniumEnvironment(); isWindowsItaniumEnvironment();
} }
/// \brief Tests whether the OS is Windows. /// Tests whether the OS is Windows.
bool isOSWindows() const { bool isOSWindows() const {
return getOS() == Triple::Win32; return getOS() == Triple::Win32;
} }
/// \brief Tests whether the OS is NaCl (Native Client) /// Tests whether the OS is NaCl (Native Client)
bool isOSNaCl() const { bool isOSNaCl() const {
return getOS() == Triple::NaCl; return getOS() == Triple::NaCl;
} }
/// \brief Tests whether the OS is Linux. /// Tests whether the OS is Linux.
bool isOSLinux() const { bool isOSLinux() const {
return getOS() == Triple::Linux; return getOS() == Triple::Linux;
} }
/// \brief Tests whether the OS uses the ELF binary format. /// Tests whether the OS uses the ELF binary format.
bool isOSBinFormatELF() const { bool isOSBinFormatELF() const {
return getObjectFormat() == Triple::ELF; return getObjectFormat() == Triple::ELF;
} }
/// \brief Tests whether the OS uses the COFF binary format. /// Tests whether the OS uses the COFF binary format.
bool isOSBinFormatCOFF() const { bool isOSBinFormatCOFF() const {
return getObjectFormat() == Triple::COFF; return getObjectFormat() == Triple::COFF;
} }
/// \brief Tests whether the environment is MachO. /// Tests whether the environment is MachO.
bool isOSBinFormatMachO() const { bool isOSBinFormatMachO() const {
return getObjectFormat() == Triple::MachO; return getObjectFormat() == Triple::MachO;
} }
/// \brief Tests whether the target is the PS4 CPU /// Tests whether the target is the PS4 CPU
bool isPS4CPU() const { bool isPS4CPU() const {
return getArch() == Triple::x86_64 && return getArch() == Triple::x86_64 &&
getVendor() == Triple::SCEI && getVendor() == Triple::SCEI &&
getOS() == Triple::PS4; getOS() == Triple::PS4;
} }
/// \brief Tests whether the target is the PS4 platform /// Tests whether the target is the PS4 platform
bool isPS4() const { bool isPS4() const {
return getVendor() == Triple::SCEI && return getVendor() == Triple::SCEI &&
getOS() == Triple::PS4; getOS() == Triple::PS4;
} }
/// \brief Tests whether the target is Android /// Tests whether the target is Android
bool isAndroid() const { return getEnvironment() == Triple::Android; } bool isAndroid() const { return getEnvironment() == Triple::Android; }
/// @} /// @}
@ -591,7 +593,7 @@ public:
/// @name Helpers to build variants of a particular triple. /// @name Helpers to build variants of a particular triple.
/// @{ /// @{
/// \brief Form a triple with a 32-bit variant of the current architecture. /// Form a triple with a 32-bit variant of the current architecture.
/// ///
/// This can be used to move across "families" of architectures where useful. /// This can be used to move across "families" of architectures where useful.
/// ///
@ -599,7 +601,7 @@ public:
/// architecture if no such variant can be found. /// architecture if no such variant can be found.
llvm::Triple get32BitArchVariant() const; llvm::Triple get32BitArchVariant() const;
/// \brief Form a triple with a 64-bit variant of the current architecture. /// Form a triple with a 64-bit variant of the current architecture.
/// ///
/// This can be used to move across "families" of architectures where useful. /// This can be used to move across "families" of architectures where useful.
/// ///