maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Give Multiversion-inline functions linkonce linkage 

Since multiversion variant functions can be inline, in C they become
available-externally linkage.  This ends up causing the variants to not
be emitted, and not available to the linker.

The solution is to make sure that multiversion functions are always
emitted by marking them linkonce.

Change-Id: I897aa37c7cbba0c1eb2c57ee881d5000a2113b75
llvm-svn: 344957
This commit is contained in:
Erich Keane 2018-10-22 21:20:45 +00:00
parent 95abadec0b
commit 7ef210d053
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -3669,6 +3669,10 @@ llvm::GlobalValue::LinkageTypes CodeGenModule::getLLVMLinkageForDeclarator(
return llvm::GlobalVariable::WeakAnyLinkage;
}
if (const auto *FD = D->getAsFunction())
if (FD->isMultiVersion() && Linkage == GVA_AvailableExternally)
return llvm::GlobalVariable::LinkOnceAnyLinkage;
// We are guaranteed to have a strong definition somewhere else,
// so we can use available_externally linkage.
if (Linkage == GVA_AvailableExternally)

16
clang/test/CodeGen/attr-target-mv.c
View File

@ -88,19 +88,19 @@ void bar4() {
// CHECK: declare i32 @foo.arch_sandybridge()
// CHECK: define available_externally i32 @foo_inline.sse4.2()
// CHECK: define linkonce i32 @foo_inline.sse4.2()
// CHECK: ret i32 0
// CHECK: declare i32 @foo_inline.arch_sandybridge()
//
// CHECK: define available_externally i32 @foo_inline.arch_ivybridge()
// CHECK: define linkonce i32 @foo_inline.arch_ivybridge()
// CHECK: ret i32 1
// CHECK: define available_externally i32 @foo_inline()
// CHECK: define linkonce i32 @foo_inline()
// CHECK: ret i32 2
// CHECK: define available_externally void @foo_decls()
// CHECK: define available_externally void @foo_decls.sse4.2()
// CHECK: define linkonce void @foo_decls()
// CHECK: define linkonce void @foo_decls.sse4.2()
// CHECK: define available_externally void @foo_multi.avx_sse4.2()
// CHECK: define available_externally void @foo_multi.fma4_sse4.2()
// CHECK: define available_externally void @foo_multi.arch_ivybridge_fma4_sse4.2()
// CHECK: define linkonce void @foo_multi.avx_sse4.2()
// CHECK: define linkonce void @foo_multi.fma4_sse4.2()
// CHECK: define linkonce void @foo_multi.arch_ivybridge_fma4_sse4.2()