[Windows] Don't try to wildcard expand paths starting with \\?\

Paths that start with `\\?\` are absolute paths, and aren't expected
to be used with wildcard expressions.

Previously, the `?` at the start of the path triggered the condition
for a potential wildcard, which caused the path to be split and
reassembled. In builds with `LLVM_WINDOWS_PREFER_FORWARD_SLASH=ON`,
this caused a path like e.g. `\\?\D:\tmp\hello.cpp` to be reassembled
into `\\?\D:\tmp/hello.cpp` which isn't a valid path (as such
absolute paths must use backslashes consistently).

This fixes https://github.com/mstorsjo/llvm-mingw/issues/280.

I'm not sure if there's any straightforward way to add a test
for this case, unfortunately.

Differential Revision: https://reviews.llvm.org/D126675
This commit is contained in:
Martin Storsjö 2022-05-29 00:44:07 +03:00
parent 298e9cac92
commit 7e2afe83e8
1 changed files with 3 additions and 2 deletions

View File

@ -156,9 +156,10 @@ static std::error_code WildcardExpand(StringRef Arg,
// Don't expand Arg if it does not contain any wildcard characters. This is
// the common case. Also don't wildcard expand /?. Always treat it as an
// option.
// option. Paths that start with \\?\ are absolute paths, and aren't
// expected to be used with wildcard expressions.
if (Arg.find_first_of("*?") == StringRef::npos || Arg == "/?" ||
Arg == "-?") {
Arg == "-?" || Arg.startswith("\\\\?\\")) {
Args.push_back(Arg.data());
return EC;
}