From 7de14dc3c60593569a93aba75e22f0085d2d3b04 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 24 Sep 2019 19:34:50 +0000 Subject: [PATCH] [unittest] Skip the socket tests if we $TMPDIR is too long. Adrian added a sanity check to the socket tests to ensure the $TMPDIR is not too long for a socket. While this is great for diagnosing the problem it doesn't really solve the problem for environment where you have no control over that variable such as in CI. I propose to just skip the test in that case similar to what we do for tests that rely on targets that are not currently build, etc. Differential revision: https://reviews.llvm.org/D67972 llvm-svn: 372774 --- lldb/unittests/Host/SocketTest.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lldb/unittests/Host/SocketTest.cpp b/lldb/unittests/Host/SocketTest.cpp index 4e897975e5d6..9408ecdaabe8 100644 --- a/lldb/unittests/Host/SocketTest.cpp +++ b/lldb/unittests/Host/SocketTest.cpp @@ -93,8 +93,10 @@ TEST_F(SocketTest, DomainListenConnectAccept) { std::error_code EC = llvm::sys::fs::createUniqueDirectory("DomainListenConnectAccept", Path); ASSERT_FALSE(EC); llvm::sys::path::append(Path, "test"); - // If this fails, $TMPDIR is too long to hold a domain socket. - EXPECT_LE(Path.size(), 107u); + + // Skip the test if the $TMPDIR is too long to hold a domain socket. + if (Path.size() > 107u) + return; std::unique_ptr socket_a_up; std::unique_ptr socket_b_up; @@ -196,8 +198,10 @@ TEST_F(SocketTest, DomainGetConnectURI) { llvm::sys::fs::createUniqueDirectory("DomainListenConnectAccept", domain_path); ASSERT_FALSE(EC); llvm::sys::path::append(domain_path, "test"); - // If this fails, $TMPDIR is too long to hold a domain socket. - EXPECT_LE(domain_path.size(), 107u); + + // Skip the test if the $TMPDIR is too long to hold a domain socket. + if (domain_path.size() > 107u) + return; std::unique_ptr socket_a_up; std::unique_ptr socket_b_up;