maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[unittest] Skip the socket tests if we $TMPDIR is too long. 

Adrian added a sanity check to the socket tests to ensure the $TMPDIR is
not too long for a socket. While this is great for diagnosing the
problem it doesn't really solve the problem for environment where you
have no control over that variable such as in CI. I propose to just skip
the test in that case similar to what we do for tests that rely on
targets that are not currently build, etc.

Differential revision: https://reviews.llvm.org/D67972

llvm-svn: 372774
This commit is contained in:
Jonas Devlieghere 2019-09-24 19:34:50 +00:00
parent 1282889347
commit 7de14dc3c6
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lldb/unittests/Host/SocketTest.cpp
View File

@ -93,8 +93,10 @@ TEST_F(SocketTest, DomainListenConnectAccept) {
std::error_code EC = llvm::sys::fs::createUniqueDirectory("DomainListenConnectAccept", Path);
ASSERT_FALSE(EC);
llvm::sys::path::append(Path, "test");
// If this fails, $TMPDIR is too long to hold a domain socket.
EXPECT_LE(Path.size(), 107u);
// Skip the test if the $TMPDIR is too long to hold a domain socket.
if (Path.size() > 107u)
return;
std::unique_ptr<DomainSocket> socket_a_up;
std::unique_ptr<DomainSocket> socket_b_up;
@ -196,8 +198,10 @@ TEST_F(SocketTest, DomainGetConnectURI) {
llvm::sys::fs::createUniqueDirectory("DomainListenConnectAccept", domain_path);
ASSERT_FALSE(EC);
llvm::sys::path::append(domain_path, "test");
// If this fails, $TMPDIR is too long to hold a domain socket.
EXPECT_LE(domain_path.size(), 107u);
// Skip the test if the $TMPDIR is too long to hold a domain socket.
if (domain_path.size() > 107u)
return;
std::unique_ptr<DomainSocket> socket_a_up;
std::unique_ptr<DomainSocket> socket_b_up;