diff --git a/llvm/lib/Bytecode/Reader/Reader.cpp b/llvm/lib/Bytecode/Reader/Reader.cpp index 398ecfc37292..75460c66fd1e 100644 --- a/llvm/lib/Bytecode/Reader/Reader.cpp +++ b/llvm/lib/Bytecode/Reader/Reader.cpp @@ -412,9 +412,12 @@ Value * BytecodeReader::getValue(unsigned type, unsigned oNum, bool Create) { GlobalTyID = CompactionTypes[type-Type::FirstDerivedTyID].second; if (hasImplicitNull(GlobalTyID)) { - if (Num == 0) - return Constant::getNullValue(getType(type)); - --Num; + const Type *Ty = getType(type); + if (!isa(Ty)) { + if (Num == 0) + return Constant::getNullValue(Ty); + --Num; + } } if (GlobalTyID < ModuleValues.size() && ModuleValues[GlobalTyID]) { @@ -529,7 +532,7 @@ unsigned BytecodeReader::insertValue(Value *Val, unsigned type, ValueTab[type]->push_back(Val); - bool HasOffset = hasImplicitNull(type); + bool HasOffset = hasImplicitNull(type) && !isa(Val->getType()); return ValueTab[type]->size()-1 + HasOffset; } @@ -2141,6 +2144,9 @@ void BytecodeReader::ParseModule() { error("Cannot find initializer value."); } + if (!ConstantFwdRefs.empty()) + error("Use of undefined constants in a module"); + /// Make sure we pulled them all out. If we didn't then there's a declaration /// but a missing body. That's not allowed. if (!FunctionSignatureList.empty())