maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

A weak reference to a symbol that is only weakly referenced in 

dependencies should remain weak, not get promoted to undef or dropped.

llvm-svn: 189793
This commit is contained in:
Joerg Sonnenberger 2013-09-03 12:06:33 +00:00
parent 1ecb96f652
commit 7d5aed5ce5
4 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lld/lib/ReaderWriter/ELF/DynamicFile.h
View File

@ -57,7 +57,9 @@ public:
if (i->st_shndx == llvm::ELF::SHN_ABS)
continue;
if (useShlibUndefines && (i->st_shndx == llvm::ELF::SHN_UNDEF)) {
if (i->st_shndx == llvm::ELF::SHN_UNDEF) {
if (!useShlibUndefines)
continue;
// Create an undefined atom.
if (!name->empty()) {
auto *newAtom =

BIN
lld/test/elf/Inputs/libweaksym.so Executable file
View File

Binary file not shown.

BIN
lld/test/elf/Inputs/weaksym.o Normal file
View File

Binary file not shown.

7
lld/test/elf/weaksym.test Normal file
View File

@ -0,0 +1,7 @@
# Tests that a weak reference remains a weak reference,
# even if a shared library defines the symbol weak as well.
RUN: lld -flavor gnu -target x86_64 -shared %p/Inputs/weaksym.o -L%p/Inputs -lweaksym -o %t1
RUN: llvm-nm -n %t1 | FileCheck -check-prefix CHECKSYMS %s
CHECKSYMS: w weaksym