maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[NFC] Don't define static function in header (UninitializedObject.h) 

Summary:
See also http://lists.llvm.org/pipermail/cfe-users/2016-January/000854.html for
the reasons why it's bad.

Reviewers: Szelethus, erichkeane

Reviewed By: Szelethus

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D50963

llvm-svn: 340174
This commit is contained in:
Andrei Elovikov 2018-08-20 13:45:38 +00:00
parent 1a00042270
commit 7d408ff662
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
View File

@ -233,7 +233,7 @@ private:
/// value is undefined or not, such as ints and doubles, can be analyzed with
/// ease. This also helps ensuring that every special field type is handled
/// correctly.
static bool isPrimitiveType(const QualType &T) {
inline bool isPrimitiveType(const QualType &T) {
return T->isBuiltinType() || T->isEnumeralType() || T->isMemberPointerType();
}

6
clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp
View File

@ -215,12 +215,10 @@ bool FindUninitializedFields::isPointerOrReferenceUninit(
llvm_unreachable("All cases are handled!");
}
// Temporary variable to avoid warning from -Wunused-function.
bool IsPrimitive = isPrimitiveType(DynT->getPointeeType());
assert((IsPrimitive || DynT->isAnyPointerType() || DynT->isReferenceType()) &&
assert((isPrimitiveType(DynT->getPointeeType()) || DynT->isAnyPointerType() ||
DynT->isReferenceType()) &&
"At this point FR must either have a primitive dynamic type, or it "
"must be a null, undefined, unknown or concrete pointer!");
(void)IsPrimitive;
if (isPrimitiveUninit(DerefdV)) {
if (NeedsCastBack)