maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[analyzer] Remove custom rule for OSIterator in RetainCountChecker 

Differential Revision: https://reviews.llvm.org/D53628

llvm-svn: 345339
This commit is contained in:
George Karpenkov 2018-10-25 23:38:24 +00:00
parent 3c2ed8f338
commit 7cdccb1459
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp
View File

@ -69,10 +69,6 @@ static bool isOSObjectDynamicCast(StringRef S) {
return S == "safeMetaCast"; return S == "safeMetaCast";
} }
static bool isOSIteratorSubclass(const Decl *D) {
return isSubclass(D, "OSIterator");
}
static bool hasRCAnnotation(const Decl *D, StringRef rcAnnotation) { static bool hasRCAnnotation(const Decl *D, StringRef rcAnnotation) {
for (const auto *Ann : D->specific_attrs<AnnotateAttr>()) { for (const auto *Ann : D->specific_attrs<AnnotateAttr>()) {
if (Ann->getAnnotation() == rcAnnotation) if (Ann->getAnnotation() == rcAnnotation)
@ -240,10 +236,6 @@ RetainSummaryManager::generateSummary(const FunctionDecl *FD,
// All objects returned with functions starting with "get" are getters. // All objects returned with functions starting with "get" are getters.
if (II->getName().startswith("get")) { if (II->getName().startswith("get")) {
// ...except for iterators.
if (isOSIteratorSubclass(PD))
return getOSSummaryCreateRule(FD);
return getOSSummaryGetRule(FD); return getOSSummaryGetRule(FD);
} else { } else {
return getOSSummaryCreateRule(FD); return getOSSummaryCreateRule(FD);