diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index c726d90f2e35..b0b5e7d387f7 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -2437,6 +2437,48 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, D->getType().isConstant(Context) && isExternallyVisible(D->getLinkageAndVisibility().getLinkage())) GV->setSection(".cp.rodata"); + + // Check if we a have a const declaration with an initializer, we may be + // able to emit it as available_externally to expose it's value to the + // optimizer. + if (Context.getLangOpts().CPlusPlus && GV->hasExternalLinkage() && + D->getType().isConstQualified() && !GV->hasInitializer() && + !D->hasDefinition() && D->hasInit() && !D->hasAttr()) { + const auto *Record = + Context.getBaseElementType(D->getType())->getAsCXXRecordDecl(); + bool HasMutableFields = Record && Record->hasMutableFields(); + if (!HasMutableFields) { + const VarDecl *InitDecl; + const Expr *InitExpr = D->getAnyInitializer(InitDecl); + if (InitExpr) { + ConstantEmitter emitter(*this); + llvm::Constant *Init = emitter.tryEmitForInitializer(*InitDecl); + if (Init) { + auto *InitType = Init->getType(); + if (GV->getType()->getElementType() != InitType) { + // The type of the initializer does not match the definition. + // This happens when an initializer has a different type from + // the type of the global (because of padding at the end of a + // structure for instance). + GV->setName(StringRef()); + // Make a new global with the correct type, this is now guaranteed + // to work. + auto *NewGV = cast( + GetAddrOfGlobalVar(D, InitType, IsForDefinition)); + + // Erase the old global, since it is no longer used. + cast(GV)->eraseFromParent(); + GV = NewGV; + } else { + GV->setInitializer(Init); + GV->setConstant(true); + GV->setLinkage(llvm::GlobalValue::AvailableExternallyLinkage); + } + emitter.finalize(GV); + } + } + } + } } auto ExpectedAS = diff --git a/clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp b/clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp new file mode 100644 index 000000000000..6c520038e941 --- /dev/null +++ b/clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp @@ -0,0 +1,68 @@ +// RUN: %clang_cc1 -std=c++11 %s -emit-llvm -o - -triple x86_64-linux-gnu | FileCheck %s --check-prefix=CHECK --check-prefix=CXX11 +// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - -triple x86_64-linux-gnu | FileCheck %s --check-prefix=CHECK --check-prefix=CXX17 + +struct A { + static const int Foo = 123; +}; +// CHECK: @_ZN1A3FooE = constant i32 123, align 4 +const int *p = &A::Foo; // emit available_externally +const int A::Foo; // convert to full definition + +struct PODWithInit { + int g = 42; + char h = 43; +}; +struct CreatePOD { + // Deferred initialization of the structure here requires changing + // the type of the global variable: the initializer list does not include + // the tail padding. + // CXX11: @_ZN9CreatePOD3podE = available_externally constant { i32, i8 } { i32 42, i8 43 }, + static constexpr PODWithInit pod{}; +}; +const int *p_pod = &CreatePOD::pod.g; + +struct Bar { + int b; +}; + +struct MutableBar { + mutable int b; +}; + +struct Foo { + // CXX11: @_ZN3Foo21ConstexprStaticMemberE = available_externally constant i32 42, + // CXX17: @_ZN3Foo21ConstexprStaticMemberE = linkonce_odr constant i32 42, + static constexpr int ConstexprStaticMember = 42; + // CHECK: @_ZN3Foo17ConstStaticMemberE = available_externally constant i32 43, + static const int ConstStaticMember = 43; + + // CXX11: @_ZN3Foo23ConstStaticStructMemberE = available_externally constant %struct.Bar { i32 44 }, + // CXX17: @_ZN3Foo23ConstStaticStructMemberE = linkonce_odr constant %struct.Bar { i32 44 }, + static constexpr Bar ConstStaticStructMember = {44}; + + // CXX11: @_ZN3Foo34ConstexprStaticMutableStructMemberE = external global %struct.MutableBar, + // CXX17: @_ZN3Foo34ConstexprStaticMutableStructMemberE = linkonce_odr global %struct.MutableBar { i32 45 }, + static constexpr MutableBar ConstexprStaticMutableStructMember = {45}; +}; +// CHECK: @_ZL15ConstStaticexpr = internal constant i32 46, +static constexpr int ConstStaticexpr = 46; +// CHECK: @_ZL9ConstExpr = internal constant i32 46, align 4 +static const int ConstExpr = 46; + +// CHECK: @_ZL21ConstexprStaticStruct = internal constant %struct.Bar { i32 47 }, +static constexpr Bar ConstexprStaticStruct = {47}; + +// CHECK: @_ZL28ConstexprStaticMutableStruct = internal global %struct.MutableBar { i32 48 }, +static constexpr MutableBar ConstexprStaticMutableStruct = {48}; + +void use(const int &); +void foo() { + use(Foo::ConstexprStaticMember); + use(Foo::ConstStaticMember); + use(Foo::ConstStaticStructMember.b); + use(Foo::ConstexprStaticMutableStructMember.b); + use(ConstStaticexpr); + use(ConstExpr); + use(ConstexprStaticStruct.b); + use(ConstexprStaticMutableStruct.b); +}