forked from OSchip/llvm-project
[clang-repl] Remove memory leak of ASTContext/TargetMachine.
Removes memory leak of ASTContext and TargetMachine. When DisableFree is turned on, it intentionally leaks these instances as they can be trivially deallocated. This patch turns this off and delete Parser instance early so that they will not reference dangling pargma headers. Asan shouldn't detect these as leaks normally, since burypointer is called for them. But, every invocation of incremental parser createa an additional leak of TargetMachine. If there are many invocations within a single test case, we easily reach number of leaks exceeding kGraveYardMaxSize (which is 12) and leaks start to get reported by asan buildbots. Reviewed By: v.g.vassilev Differential Revision: https://reviews.llvm.org/D127991
This commit is contained in:
parent
8da8b61430
commit
7bc00ce5cd
|
@ -134,7 +134,10 @@ IncrementalParser::IncrementalParser(std::unique_ptr<CompilerInstance> Instance,
|
|||
P->Initialize();
|
||||
}
|
||||
|
||||
IncrementalParser::~IncrementalParser() { Act->FinalizeAction(); }
|
||||
IncrementalParser::~IncrementalParser() {
|
||||
P.reset();
|
||||
Act->FinalizeAction();
|
||||
}
|
||||
|
||||
llvm::Expected<PartialTranslationUnit &>
|
||||
IncrementalParser::ParseOrWrapTopLevelDecl() {
|
||||
|
|
|
@ -116,6 +116,9 @@ CreateCI(const llvm::opt::ArgStringList &Argv) {
|
|||
// times, reusing the same AST.
|
||||
Clang->getCodeGenOpts().ClearASTBeforeBackend = false;
|
||||
|
||||
Clang->getFrontendOpts().DisableFree = false;
|
||||
Clang->getCodeGenOpts().DisableFree = false;
|
||||
|
||||
return std::move(Clang);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue