maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Add the actually calculated completions to COMPLETION_MSG 

Summary: Otherwise this assertion message is not very useful to whoever is reading the log.

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D49947

llvm-svn: 338179
This commit is contained in:
Raphael Isemann 2018-07-27 23:42:34 +00:00
parent 2f6a1018e0
commit 7bb4de47c9
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py
View File

@ -313,8 +313,8 @@ class CommandLineCompletionTestCase(TestBase):
if turn_off_re_match:
self.expect(
compare_string, msg=COMPLETION_MSG(
str_input, p), exe=False, substrs=[p])
str_input, p, match_strings), exe=False, substrs=[p])
else:
self.expect(
compare_string, msg=COMPLETION_MSG(
str_input, p), exe=False, patterns=[p])
str_input, p, match_strings), exe=False, patterns=[p])

5
lldb/packages/Python/lldbsuite/test/lldbtest.py
View File

@ -184,9 +184,10 @@ def CMD_MSG(str):
return "Command '%s' returns successfully" % str
def COMPLETION_MSG(str_before, str_after):
def COMPLETION_MSG(str_before, str_after, completions):
'''A generic message generator for the completion mechanism.'''
return "'%s' successfully completes to '%s'" % (str_before, str_after)
return ("'%s' successfully completes to '%s', but completions were:\n%s"
% (str_before, str_after, "\n".join(completions)))
def EXP_MSG(str, actual, exe):